From: Jonathan Cameron <jic23@kernel.org>
To: Arthur-Prince <r2.arthur.prince@gmail.com>
Cc: linux-iio@vger.kernel.org, arthur.prince@ime.usp.br,
"Mariana Valério" <mariana.valerio2@hotmail.com>
Subject: Re: [PATCH 2/2] iio: adc: Kconfig: add kfifo dependency to fix module build
Date: Sat, 26 Apr 2025 16:32:24 +0100 [thread overview]
Message-ID: <20250426163224.5b367eb5@jic23-huawei> (raw)
In-Reply-To: <20250423185208.752080-3-r2.arthur.prince@gmail.com>
On Wed, 23 Apr 2025 15:46:26 -0300
Arthur-Prince <r2.arthur.prince@gmail.com> wrote:
> Add dependency to Kconfig’s ti-ads1298 because compiling it as a module
> failed with an undefined kfifo symbol. Building the full kernel passed
> since kfifo was enabled globally. Selecting IIO_KFIFO_BUFFER in
> ti-ads1298’s Kconfig, as done by other IIO ADC drivers, now ensures kfifo
> buffer support is included for module builds.
>
> Signed-off-by: Arthur-Prince <r2.arthur.prince@gmail.com>
> Co-developed-by: Mariana Valério <mariana.valerio2@hotmail.com>
> Signed-off-by: Mariana Valério <mariana.valerio2@hotmail.com>
Fixes tag?
Otherwise looks good.
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index 849c90203071..513f2238fdee 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -1492,6 +1492,7 @@ config TI_ADS1298
> tristate "Texas Instruments ADS1298"
> depends on SPI
> select IIO_BUFFER
> + select IIO_KFIFO_BUF
> help
> If you say yes here you get support for Texas Instruments ADS1298
> medical ADC chips
prev parent reply other threads:[~2025-04-26 15:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 18:46 [PATCH 0/2] iio: adc: ti-ads1298 & Kconfig Arthur-Prince
2025-04-23 18:46 ` [PATCH 1/2] iio: adc: ti-ads1298: Add safe usage guarantee for device communication Arthur-Prince
2025-04-26 15:30 ` Jonathan Cameron
2025-04-23 18:46 ` [PATCH 2/2] iio: adc: Kconfig: add kfifo dependency to fix module build Arthur-Prince
2025-04-26 15:32 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250426163224.5b367eb5@jic23-huawei \
--to=jic23@kernel.org \
--cc=arthur.prince@ime.usp.br \
--cc=linux-iio@vger.kernel.org \
--cc=mariana.valerio2@hotmail.com \
--cc=r2.arthur.prince@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox