Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Fabio Estevam <festevam@gmail.com>,
	linux-iio@vger.kernel.org, Fabio Estevam <festevam@denx.de>,
	stable@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: adc: max1363: Reorder mode_list[] entries
Date: Sun, 25 May 2025 12:21:25 +0100	[thread overview]
Message-ID: <20250525122125.201114e2@jic23-huawei> (raw)
In-Reply-To: <b6113648-1832-49eb-a14e-460c388c3e53@gmail.com>

On Mon, 19 May 2025 08:02:33 +0300
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 16/05/2025 20:39, Fabio Estevam wrote:
> > From: Fabio Estevam <festevam@denx.de>
> > 
> > The IIO core issues warnings when a scan mask is a subset of a previous
> > entry in the available_scan_masks array.
> > 
> > On a board using a MAX11601, the following warning is observed:
> > 
> > max1363 1-0064: available_scan_mask 7 subset of 6. Never used
> > 
> > This occurs because the entries in the max11607_mode_list[] array are not
> > ordered correctly. To fix this, reorder the entries so that no scan mask is
> > a subset of an earlier one.
> > 
> > While at it, reorder the mode_list[] arrays for other supported chips as
> > well, to prevent similar warnings on different variants.
> > 
> > Cc: stable@vger.kernel.org
> > Fixes: 2718f15403fb ("iio: sanity check available_scan_masks array")  
> 
> Same comment as for patch1/2
> 
> Yours,
> 	-- Matti
Likewise, dropped the fixes tag.  Admittedly that's the somewhat lazy
option.  I'd less fussed than normal on this because the worst that
happens is we print warnings and sample more channels than strictly
necessary.

Jonathan


  reply	other threads:[~2025-05-25 11:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-16 17:38 [PATCH v2 1/2] iio: adc: max1363: Fix MAX1363_4X_CHANS/MAX1363_8X_CHANS[] Fabio Estevam
2025-05-16 17:39 ` [PATCH v2 2/2] iio: adc: max1363: Reorder mode_list[] entries Fabio Estevam
2025-05-19  5:02   ` Matti Vaittinen
2025-05-25 11:21     ` Jonathan Cameron [this message]
2025-05-19  5:01 ` [PATCH v2 1/2] iio: adc: max1363: Fix MAX1363_4X_CHANS/MAX1363_8X_CHANS[] Matti Vaittinen
2025-05-20  0:31   ` Fabio Estevam
2025-05-25 13:10     ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250525122125.201114e2@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=festevam@denx.de \
    --cc=festevam@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=mazziesaccount@gmail.com \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox