From: Jonathan Cameron <jic23@kernel.org>
To: Fabio Estevam <festevam@gmail.com>
Cc: Matti Vaittinen <mazziesaccount@gmail.com>,
linux-iio@vger.kernel.org, Fabio Estevam <festevam@denx.de>,
stable@vger.kernel.org
Subject: Re: [PATCH v2 1/2] iio: adc: max1363: Fix MAX1363_4X_CHANS/MAX1363_8X_CHANS[]
Date: Sun, 25 May 2025 14:10:05 +0100 [thread overview]
Message-ID: <20250525141005.626ac223@jic23-huawei> (raw)
In-Reply-To: <CAOMZO5CtcmpH6sMpHboEyP50iPG3qGAyzg+TEoR7w2-ykU44_g@mail.gmail.com>
On Mon, 19 May 2025 21:31:22 -0300
Fabio Estevam <festevam@gmail.com> wrote:
> Hi Matti,
>
> On Mon, May 19, 2025 at 2:01 AM Matti Vaittinen
> <mazziesaccount@gmail.com> wrote:
>
> > I could argue the problem which is fixed is not related to the
> > 2718f15403fb. I'd say the problem has been the commit which introduced
> > the 'offending' masks instead. The 2718f15403fb is not fixed by this
> > change. It could help identifying the faulty releases if correct commit
> > was pointed here.
>
> Fair enough, thanks.
>
> I am going through this driver's history, and it looks like the masks
> have been always wrong, since the beginning.
>
> I was not able to point to an exact commit, though.
>
> Maybe I can remove the Fixes line. Jonathan?
Hmm. I agree this one is misleading and the history
get it right complex (and depends on introduction of various devices
over time.
I'll drop the fixes tag and apply. Note this will only go upstream
after rc1.
prev parent reply other threads:[~2025-05-25 13:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-16 17:38 [PATCH v2 1/2] iio: adc: max1363: Fix MAX1363_4X_CHANS/MAX1363_8X_CHANS[] Fabio Estevam
2025-05-16 17:39 ` [PATCH v2 2/2] iio: adc: max1363: Reorder mode_list[] entries Fabio Estevam
2025-05-19 5:02 ` Matti Vaittinen
2025-05-25 11:21 ` Jonathan Cameron
2025-05-19 5:01 ` [PATCH v2 1/2] iio: adc: max1363: Fix MAX1363_4X_CHANS/MAX1363_8X_CHANS[] Matti Vaittinen
2025-05-20 0:31 ` Fabio Estevam
2025-05-25 13:10 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250525141005.626ac223@jic23-huawei \
--to=jic23@kernel.org \
--cc=festevam@denx.de \
--cc=festevam@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=mazziesaccount@gmail.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox