[PATCH] iio: accel: adxl345: make ad8366_info const

[PATCH] iio: accel: adxl345: make ad8366_info const

[David Lechner]

Add const qualifier to struct ad8366_info ad8366_infos[]. This
is read-only data so it can be made const.

Signed-off-by: David Lechner <dlechner@baylibre.com>
---
I looked into dropping use of the chip info array in this one, but
removing it isn't trivial. There are several switch statements that
are using the chip ID still. So we'll save that for another day.
---
 drivers/iio/amplifiers/ad8366.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/iio/amplifiers/ad8366.c b/drivers/iio/amplifiers/ad8366.c
index e73c9b9833959e498fd03b37f9bedf2226b2f42a..d06ac786501c47518493e382ec2e2ad445349dd6 100644
--- a/drivers/iio/amplifiers/ad8366.c
+++ b/drivers/iio/amplifiers/ad8366.c
@@ -45,7 +45,7 @@ struct ad8366_state {
 	struct gpio_desc	*reset_gpio;
 	unsigned char		ch[2];
 	enum ad8366_type	type;
-	struct ad8366_info	*info;
+	const struct ad8366_info *info;
 	/*
 	 * DMA (thus cache coherency maintenance) may require the
 	 * transfer buffers to live in their own cache lines.
@@ -53,7 +53,7 @@ struct ad8366_state {
 	unsigned char		data[2] __aligned(IIO_DMA_MINALIGN);
 };
 
-static struct ad8366_info ad8366_infos[] = {
+static const struct ad8366_info ad8366_infos[] = {
 	[ID_AD8366] = {
 		.gain_min = 4500,
 		.gain_max = 20500,
@@ -163,7 +163,7 @@ static int ad8366_write_raw(struct iio_dev *indio_dev,
 			    long mask)
 {
 	struct ad8366_state *st = iio_priv(indio_dev);
-	struct ad8366_info *inf = st->info;
+	const struct ad8366_info *inf = st->info;
 	int code = 0, gain;
 	int ret;
 

---
base-commit: 14071b9cf2d751ff9bc8b5e43fa94fbf08aceea1
change-id: 20250628-iio-const-data-12-28e1f81b4463

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH] iio: amplifiers: ad8366: make ad8366_info const

[David Lechner]

On 6/28/25 12:01 PM, David Lechner wrote:
> Add const qualifier to struct ad8366_info ad8366_infos[]. This
> is read-only data so it can be made const.
> 
> Signed-off-by: David Lechner <dlechner@baylibre.com>
> ---
> I looked into dropping use of the chip info array in this one, but
> removing it isn't trivial. There are several switch statements that
> are using the chip ID still. So we'll save that for another day.
> ---
>  drivers/iio/amplifiers/ad8366.c | 6 +++---

Replying with the correct subject. I missed updating the prefix
from a copied commit message.

Should be `iio: amplifiers: ad8366:`

>  1 file changed, 3 insertions(+), 3 deletions(-)
> 

Re: [PATCH] iio: amplifiers: ad8366: make ad8366_info const

[Jonathan Cameron]

On Sat, 28 Jun 2025 12:05:03 -0500
David Lechner <dlechner@baylibre.com> wrote:

> On 6/28/25 12:01 PM, David Lechner wrote:
> > Add const qualifier to struct ad8366_info ad8366_infos[]. This
> > is read-only data so it can be made const.
> > 
> > Signed-off-by: David Lechner <dlechner@baylibre.com>
> > ---
> > I looked into dropping use of the chip info array in this one, but
> > removing it isn't trivial. There are several switch statements that
> > are using the chip ID still. So we'll save that for another day.
> > ---
> >  drivers/iio/amplifiers/ad8366.c | 6 +++---  
> 
> Replying with the correct subject. I missed updating the prefix
> from a copied commit message.
> 
> Should be `iio: amplifiers: ad8366:`
Fixed up and applied to the testing branch of iio.git on the
perhaps foolish basis "it's obviously correct" :)

> 
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >   
>