* [PATCH] iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE
@ 2025-07-15 6:40 Arnd Bergmann
2025-07-15 15:39 ` David Lechner
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2025-07-15 6:40 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Andy Shevchenko, Nuno Sá
Cc: Arnd Bergmann, Andy Shevchenko, Marcelo Schmitt, Javier Carrasco,
Matti Vaittinen, Tobias Sperling, Antoniu Miclaus, linux-iio,
linux-kernel
From: Arnd Bergmann <arnd@arndb.de>
The newly added support for SPI offloading causes a link error
when the dmaengine buffer helpers are unavailable:
arm-linux-gnueabi-ld: drivers/iio/adc/ad_sigma_delta.o: in function `devm_ad_sd_setup_buffer_and_trigger':
ad_sigma_delta.c:(.text+0x6b8): undefined reference to `devm_iio_dmaengine_buffer_setup_with_handle'
Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
drivers/iio/adc/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
index d43edc7b0c0f..e2649739a2da 100644
--- a/drivers/iio/adc/Kconfig
+++ b/drivers/iio/adc/Kconfig
@@ -23,6 +23,7 @@ config AD_SIGMA_DELTA
tristate
select IIO_BUFFER
select IIO_TRIGGERED_BUFFER
+ select IIO_BUFFER_DMAENGINE
config AD4000
tristate "Analog Devices AD4000 ADC Driver"
--
2.39.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE
2025-07-15 6:40 [PATCH] iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE Arnd Bergmann
@ 2025-07-15 15:39 ` David Lechner
0 siblings, 0 replies; 2+ messages in thread
From: David Lechner @ 2025-07-15 15:39 UTC (permalink / raw)
To: Arnd Bergmann, Jonathan Cameron, Andy Shevchenko, Nuno Sá
Cc: Arnd Bergmann, Andy Shevchenko, Marcelo Schmitt, Javier Carrasco,
Matti Vaittinen, Tobias Sperling, Antoniu Miclaus, linux-iio,
linux-kernel
On 7/15/25 1:40 AM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The newly added support for SPI offloading causes a link error
> when the dmaengine buffer helpers are unavailable:
>
> arm-linux-gnueabi-ld: drivers/iio/adc/ad_sigma_delta.o: in function `devm_ad_sd_setup_buffer_and_trigger':
> ad_sigma_delta.c:(.text+0x6b8): undefined reference to `devm_iio_dmaengine_buffer_setup_with_handle'
>
> Fixes: 219da3ea842a ("iio: adc: ad_sigma_delta: add SPI offload support")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> drivers/iio/adc/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/iio/adc/Kconfig b/drivers/iio/adc/Kconfig
> index d43edc7b0c0f..e2649739a2da 100644
> --- a/drivers/iio/adc/Kconfig
> +++ b/drivers/iio/adc/Kconfig
> @@ -23,6 +23,7 @@ config AD_SIGMA_DELTA
> tristate
> select IIO_BUFFER
> select IIO_TRIGGERED_BUFFER
> + select IIO_BUFFER_DMAENGINE
>
> config AD4000
> tristate "Analog Devices AD4000 ADC Driver"
Thanks, but I think [1] is a more complete fix.
[1]: https://lore.kernel.org/linux-iio/20250714-iio-ad_sigma_delta-fix-kconfig-selects-v1-1-32e0d6da0423@kernel.org/
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-15 15:39 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-07-15 6:40 [PATCH] iio: adc: ad_sigma_delta: select CONFIG_IIO_BUFFER_DMAENGINE Arnd Bergmann
2025-07-15 15:39 ` David Lechner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox