Re: [PATCH] iio: adc: Add Intel Dollar Cove TI PMIC ADC driver

[Jonathan Cameron <jic23@kernel.org>]

> >> +	ret = wait_event_timeout(info->wait, info->conversion_done, 5 * HZ);
> >> +	if (ret == 0) {
> >> +		dev_err(info->dev, "Error sample timeout\n");
> >> +		ret = -ETIMEDOUT;
> >> +		goto disable_adc;
> >> +	}
> >> +
> >> +	ret = regmap_read(info->regmap, chan->address, &msb);
> >> +	if (ret)
> >> +		goto disable_adc;
> >> +
> >> +	ret = regmap_read(info->regmap, chan->address + 1, &lsb);  
> > bulk read and an endian conversion + mask?  
> 
> This chip only supports reading 1 register at a time, I'll add
> a comment about this.

Set regmap_config.use_single_read and bulk reads should be fine.

> 
> >   
> >> +	if (ret)
> >> +		goto disable_adc;

Jonathan