Re: [PATCH] iio: adc: Add Intel Dollar Cove TI PMIC ADC driver

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 19 Jul 2025 18:17:15 +0200
Hans de Goede <hansg@kernel.org> wrote:

> Hi Jonathan,
> 
> On 19-Jul-25 1:04 PM, Jonathan Cameron wrote:
> >>>> +	ret = wait_event_timeout(info->wait, info->conversion_done, 5 * HZ);
> >>>> +	if (ret == 0) {
> >>>> +		dev_err(info->dev, "Error sample timeout\n");
> >>>> +		ret = -ETIMEDOUT;
> >>>> +		goto disable_adc;
> >>>> +	}
> >>>> +
> >>>> +	ret = regmap_read(info->regmap, chan->address, &msb);
> >>>> +	if (ret)
> >>>> +		goto disable_adc;
> >>>> +
> >>>> +	ret = regmap_read(info->regmap, chan->address + 1, &lsb);    
> >>> bulk read and an endian conversion + mask?    
> >>
> >> This chip only supports reading 1 register at a time, I'll add
> >> a comment about this.  
> > 
> > Set regmap_config.use_single_read and bulk reads should be fine.  
> 
> Interesting, I did not know about that flag.
> 
> But I'm afraid that I've already ending up spending more time
> then planned on supporting this old PMIC. fixing all other remarks
> from you and Linus W.
> 
> And I also hit an i2c-core regression which I've just finished
> debugging...
> 
> So I'm going to keep the multiple reg-reads as is (it won't
> matter for what happens on the I2C bus anyways) I hope this is ok.

Sure.


> 
> I did also write an interesting iio-core patch to make
> iio_read_channel_processed_scale() more precise :)
> 
> I plan to post a a new series including this tomorrow.
> 
> Regards,
> 
> Hans
> 
> 
>