From: Jonathan Cameron <jic23@kernel.org>
To: Ben Collins <bcollins@watter.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] iio: mcp9600: White space cleanup for tab alignment
Date: Sat, 16 Aug 2025 10:59:55 +0100 [thread overview]
Message-ID: <20250816105955.101622d0@jic23-huawei> (raw)
In-Reply-To: <20250815164627.22002-3-bcollins@watter.com>
On Fri, 15 Aug 2025 16:46:04 +0000
Ben Collins <bcollins@watter.com> wrote:
> Purely to align tabs for #defines.
Hi Ben,
Mention the changes to two digits for register addresses to.
Good change to roll in here given what you are touching anyway so
just make sure to call it out in the patch description.
Jonathan
>
> Signed-off-by: Ben Collins <bcollins@watter.com>
> ---
> drivers/iio/temperature/mcp9600.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/temperature/mcp9600.c b/drivers/iio/temperature/mcp9600.c
> index 6e9108d5cf75f..40906bb200ec9 100644
> --- a/drivers/iio/temperature/mcp9600.c
> +++ b/drivers/iio/temperature/mcp9600.c
> @@ -23,25 +23,25 @@
> #include <linux/iio/iio.h>
>
> /* MCP9600 registers */
> -#define MCP9600_HOT_JUNCTION 0x0
> -#define MCP9600_COLD_JUNCTION 0x2
> -#define MCP9600_STATUS 0x4
> +#define MCP9600_HOT_JUNCTION 0x00
> +#define MCP9600_COLD_JUNCTION 0x02
> +#define MCP9600_STATUS 0x04
> #define MCP9600_STATUS_ALERT(x) BIT(x)
> -#define MCP9600_ALERT_CFG1 0x8
> +#define MCP9600_ALERT_CFG1 0x08
> #define MCP9600_ALERT_CFG(x) (MCP9600_ALERT_CFG1 + (x - 1))
> #define MCP9600_ALERT_CFG_ENABLE BIT(0)
> #define MCP9600_ALERT_CFG_ACTIVE_HIGH BIT(2)
> #define MCP9600_ALERT_CFG_FALLING BIT(3)
> #define MCP9600_ALERT_CFG_COLD_JUNCTION BIT(4)
> -#define MCP9600_ALERT_HYSTERESIS1 0xc
> +#define MCP9600_ALERT_HYSTERESIS1 0x0c
> #define MCP9600_ALERT_HYSTERESIS(x) (MCP9600_ALERT_HYSTERESIS1 + (x - 1))
> #define MCP9600_ALERT_LIMIT1 0x10
> #define MCP9600_ALERT_LIMIT(x) (MCP9600_ALERT_LIMIT1 + (x - 1))
> #define MCP9600_ALERT_LIMIT_MASK GENMASK(15, 2)
> -#define MCP9600_DEVICE_ID 0x20
> +#define MCP9600_DEVICE_ID 0x20
>
> /* MCP9600 device id value */
> -#define MCP9600_DEVICE_ID_MCP9600 0x40
> +#define MCP9600_DEVICE_ID_MCP9600 0x40
>
> #define MCP9600_ALERT_COUNT 4
>
next prev parent reply other threads:[~2025-08-16 10:00 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-15 16:46 [PATCH 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-15 16:46 ` [PATCH 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601 Ben Collins
2025-08-16 9:58 ` Jonathan Cameron
2025-08-16 18:55 ` David Lechner
2025-08-17 16:37 ` Ben Collins
2025-08-17 16:51 ` David Lechner
2025-08-17 17:34 ` Ben Collins
2025-08-17 17:59 ` David Lechner
2025-08-17 21:02 ` Ben Collins
2025-08-17 21:10 ` Ben Collins
2025-08-18 6:42 ` Krzysztof Kozlowski
2025-08-15 16:46 ` [PATCH 2/5] iio: mcp9600: White space cleanup for tab alignment Ben Collins
2025-08-16 9:59 ` Jonathan Cameron [this message]
2025-08-15 16:46 ` [PATCH 3/5] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-16 8:46 ` kernel test robot
2025-08-16 10:02 ` Jonathan Cameron
2025-08-18 15:06 ` Nathan Chancellor
2025-08-18 15:11 ` Ben Collins
2025-08-18 15:18 ` Jonathan Cameron
2025-08-16 10:04 ` Jonathan Cameron
2025-08-15 16:46 ` [PATCH 4/5] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-16 10:11 ` Jonathan Cameron
2025-08-16 13:18 ` Ben Collins
2025-08-16 15:09 ` Jonathan Cameron
2025-08-16 18:24 ` David Lechner
2025-08-17 2:54 ` Ben Collins
2025-08-17 3:32 ` David Lechner
2025-08-15 16:46 ` [PATCH 5/5] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-16 10:15 ` Jonathan Cameron
2025-08-16 17:22 ` David Lechner
2025-08-16 10:07 ` [PATCH 0/5] iio: mcp9600: Features and improvements Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250816105955.101622d0@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=bcollins@watter.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox