Linux IIO development
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ben Collins <bcollins@watter.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] iio: mcp9600: Recognize chip id for mcp9601
Date: Sat, 16 Aug 2025 11:04:58 +0100	[thread overview]
Message-ID: <20250816110458.470ea150@jic23-huawei> (raw)
In-Reply-To: <20250815164627.22002-4-bcollins@watter.com>

On Fri, 15 Aug 2025 16:46:05 +0000
Ben Collins <bcollins@watter.com> wrote:

> The current driver works with mcp9601, but emits a warning because it
> does not recognize the chip id.
> 
> MCP9601 is a superset of MCP9600. The drivers works without changes
> on this chipset.
> 
> However, the 9601 chip supports open/closed-circuit detection if wired
> properly, so we'll need to be able to differentiate between them.
> 
> Signed-off-by: Ben Collins <bcollins@watter.com>
> ---
>  drivers/iio/temperature/Kconfig   |  8 +++--
>  drivers/iio/temperature/mcp9600.c | 51 +++++++++++++++++++++++++------
>  2 files changed, 46 insertions(+), 13 deletions(-)
> 
> diff --git a/drivers/iio/temperature/Kconfig b/drivers/iio/temperature/Kconfig
> index 1244d8e17d504..e14ea6ebc7a24 100644
> --- a/drivers/iio/temperature/Kconfig
> +++ b/drivers/iio/temperature/Kconfig
> @@ -173,11 +173,13 @@ config MAX31865
>  	  will be called max31865.
>  
>  config MCP9600
> -	tristate "MCP9600 thermocouple EMF converter"
> +	tristate "MCP9600 and similar thermocouple EMF converters"
>  	depends on I2C
>  	help
> -	  If you say yes here you get support for MCP9600
> -	  thermocouple EMF converter connected via I2C.
> +	  If you say yes here you get support for:
> +	  - MCP9600
> +	  - MCP9601
> +	  and similar thermocouple EMF converters connected via I2C.

If we are updating this list every time, do we need to add the 'and similar'
to the help text?  It makes sense only in the short description above where
we aren't listing them.

>  
>  	  This driver can also be built as a module. If so, the module
>  	  will be called mcp9600.
>


  parent reply	other threads:[~2025-08-16 10:05 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-15 16:46 [PATCH 0/5] iio: mcp9600: Features and improvements Ben Collins
2025-08-15 16:46 ` [PATCH 1/5] dt-bindings: iio: mcp9600: Add compatible for microchip,mcp9601 Ben Collins
2025-08-16  9:58   ` Jonathan Cameron
2025-08-16 18:55     ` David Lechner
2025-08-17 16:37       ` Ben Collins
2025-08-17 16:51         ` David Lechner
2025-08-17 17:34           ` Ben Collins
2025-08-17 17:59             ` David Lechner
2025-08-17 21:02               ` Ben Collins
2025-08-17 21:10                 ` Ben Collins
2025-08-18  6:42                   ` Krzysztof Kozlowski
2025-08-15 16:46 ` [PATCH 2/5] iio: mcp9600: White space cleanup for tab alignment Ben Collins
2025-08-16  9:59   ` Jonathan Cameron
2025-08-15 16:46 ` [PATCH 3/5] iio: mcp9600: Recognize chip id for mcp9601 Ben Collins
2025-08-16  8:46   ` kernel test robot
2025-08-16 10:02     ` Jonathan Cameron
2025-08-18 15:06       ` Nathan Chancellor
2025-08-18 15:11         ` Ben Collins
2025-08-18 15:18         ` Jonathan Cameron
2025-08-16 10:04   ` Jonathan Cameron [this message]
2025-08-15 16:46 ` [PATCH 4/5] iio: mcp9600: Add support for thermocouple-type Ben Collins
2025-08-16 10:11   ` Jonathan Cameron
2025-08-16 13:18     ` Ben Collins
2025-08-16 15:09       ` Jonathan Cameron
2025-08-16 18:24   ` David Lechner
2025-08-17  2:54     ` Ben Collins
2025-08-17  3:32       ` David Lechner
2025-08-15 16:46 ` [PATCH 5/5] iio: mcp9600: Add support for IIR filter Ben Collins
2025-08-16 10:15   ` Jonathan Cameron
2025-08-16 17:22   ` David Lechner
2025-08-16 10:07 ` [PATCH 0/5] iio: mcp9600: Features and improvements Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250816110458.470ea150@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andy@kernel.org \
    --cc=bcollins@watter.com \
    --cc=dlechner@baylibre.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox