* [PATCH] iio: adc: ad7124: use devm_mutex_init()
@ 2025-09-17 15:22 David Lechner
2025-09-20 11:06 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: David Lechner @ 2025-09-17 15:22 UTC (permalink / raw)
To: Michael Hennerich, Jonathan Cameron, Nuno Sá,
Andy Shevchenko
Cc: linux-iio, linux-kernel, David Lechner
Use devm_mutex_init() to initialize the mutex to handle automatically
freeing in debug builds.
Signed-off-by: David Lechner <dlechner@baylibre.com>
---
drivers/iio/adc/ad7124.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
index 9ace3e0914f5acab695c0382df758f56f333ae72..9d9250274b9a02e2982e6ceda27009a84413dc2f 100644
--- a/drivers/iio/adc/ad7124.c
+++ b/drivers/iio/adc/ad7124.c
@@ -1482,7 +1482,10 @@ static int ad7124_setup(struct ad7124_state *st)
st->adc_control &= ~AD7124_ADC_CONTROL_MODE;
st->adc_control |= FIELD_PREP(AD7124_ADC_CONTROL_MODE, AD_SD_MODE_IDLE);
- mutex_init(&st->cfgs_lock);
+ ret = devm_mutex_init(dev, &st->cfgs_lock);
+ if (ret)
+ return ret;
+
INIT_KFIFO(st->live_cfgs_fifo);
for (i = 0; i < st->num_channels; i++) {
struct ad7124_channel_config *cfg = &st->channels[i].cfg;
---
base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
change-id: 20250917-iio-adc-ad7124-use-devm_mutex_init-45a297b1ff8f
Best regards,
--
David Lechner <dlechner@baylibre.com>
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] iio: adc: ad7124: use devm_mutex_init()
2025-09-17 15:22 [PATCH] iio: adc: ad7124: use devm_mutex_init() David Lechner
@ 2025-09-20 11:06 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2025-09-20 11:06 UTC (permalink / raw)
To: David Lechner
Cc: Michael Hennerich, Nuno Sá, Andy Shevchenko, linux-iio,
linux-kernel
On Wed, 17 Sep 2025 10:22:30 -0500
David Lechner <dlechner@baylibre.com> wrote:
> Use devm_mutex_init() to initialize the mutex to handle automatically
> freeing in debug builds.
>
> Signed-off-by: David Lechner <dlechner@baylibre.com>
Normally I'd say this isn't worth the churn but fine this time given
all the other patches for this driver.
Applied to iio.git/testing
Jonathan
> ---
> drivers/iio/adc/ad7124.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 9ace3e0914f5acab695c0382df758f56f333ae72..9d9250274b9a02e2982e6ceda27009a84413dc2f 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -1482,7 +1482,10 @@ static int ad7124_setup(struct ad7124_state *st)
> st->adc_control &= ~AD7124_ADC_CONTROL_MODE;
> st->adc_control |= FIELD_PREP(AD7124_ADC_CONTROL_MODE, AD_SD_MODE_IDLE);
>
> - mutex_init(&st->cfgs_lock);
> + ret = devm_mutex_init(dev, &st->cfgs_lock);
> + if (ret)
> + return ret;
> +
> INIT_KFIFO(st->live_cfgs_fifo);
> for (i = 0; i < st->num_channels; i++) {
> struct ad7124_channel_config *cfg = &st->channels[i].cfg;
>
> ---
> base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
> change-id: 20250917-iio-adc-ad7124-use-devm_mutex_init-45a297b1ff8f
>
> Best regards,
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-20 11:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-09-17 15:22 [PATCH] iio: adc: ad7124: use devm_mutex_init() David Lechner
2025-09-20 11:06 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox