From: Taimoor Zaeem <taimoorzaeem@gmail.com>
To: gregkh@linuxfoundation.org
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, taimoorzaeem@gmail.com
Subject: Re: [PATCH] staging: iio: ad9832: move ad9832_platform_data into include/linux/lib
Date: Sun, 5 Oct 2025 19:47:58 +0500 [thread overview]
Message-ID: <20251005144758.190457-1-taimoorzaeem@gmail.com> (raw)
In-Reply-To: <2025100548-stereo-patronage-408a@gregkh>
> No, this should only happen when the whole driver moves out of
> drivers/staging/, staging drivers shoul dbe self-contained.
Right, I see.
> Also, why is a .h file needed for just one file anyway? Shouldn't this
> be part of the .c file instead?
Not sure what's the convention here, but yes it could be part of .c instead. There is another .h file in the same directory (ad9834.h) which is basically empty. Should we remove that too?
next prev parent reply other threads:[~2025-10-05 14:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 12:18 [PATCH] staging: iio: ad9832: move ad9832_platform_data into include/linux/lib Taimoor Zaeem
2025-10-05 14:00 ` Greg KH
2025-10-05 14:47 ` Taimoor Zaeem [this message]
2025-10-06 6:21 ` Greg KH
2025-10-06 10:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251005144758.190457-1-taimoorzaeem@gmail.com \
--to=taimoorzaeem@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox