From: Greg KH <gregkh@linuxfoundation.org>
To: Taimoor Zaeem <taimoorzaeem@gmail.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev
Subject: Re: [PATCH] staging: iio: ad9832: move ad9832_platform_data into include/linux/lib
Date: Sun, 5 Oct 2025 16:00:33 +0200 [thread overview]
Message-ID: <2025100548-stereo-patronage-408a@gregkh> (raw)
In-Reply-To: <20251005121829.175943-1-taimoorzaeem@gmail.com>
On Sun, Oct 05, 2025 at 05:18:29PM +0500, Taimoor Zaeem wrote:
> Move struct ad9832_platform_data from
> drivers/staging/iio/frequency/ad9832.h to
> include/linux/iio/frequency/ad9832.h.
>
> This clears a TODO item in the drivers.
No, this should only happen when the whole driver moves out of
drivers/staging/, staging drivers shoul dbe self-contained.
Also, why is a .h file needed for just one file anyway? Shouldn't this
be part of the .c file instead?
thanks,
greg k-h
next prev parent reply other threads:[~2025-10-05 14:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-05 12:18 [PATCH] staging: iio: ad9832: move ad9832_platform_data into include/linux/lib Taimoor Zaeem
2025-10-05 14:00 ` Greg KH [this message]
2025-10-05 14:47 ` Taimoor Zaeem
2025-10-06 6:21 ` Greg KH
2025-10-06 10:57 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2025100548-stereo-patronage-408a@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=taimoorzaeem@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox