From: Kurt Borja <kuurtb@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@intel.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
Benson Leung <bleung@chromium.org>,
Antoniu Miclaus <antoniu.miclaus@analog.com>,
Gwendal Grignou <gwendal@chromium.org>,
Shrikant Raskar <raskar.shree97@gmail.com>,
Per-Daniel Olsson <perdaniel.olsson@axis.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Guenter Roeck" <groeck@chromium.org>,
"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
chrome-platform@lists.linux.dev, "Kurt Borja" <kuurtb@gmail.com>
Subject: [PATCH RFC 4/6] iio: light: vcnl4000: Use cleanup.h for IIO locks
Date: Wed, 03 Dec 2025 14:18:18 -0500 [thread overview]
Message-ID: <20251203-lock-impr-v1-4-b4a1fd639423@gmail.com> (raw)
In-Reply-To: <20251203-lock-impr-v1-0-b4a1fd639423@gmail.com>
Use ACQUIRE() for iio_device_claim_direct().
Signed-off-by: Kurt Borja <kuurtb@gmail.com>
---
drivers/iio/light/vcnl4000.c | 24 ++++++++----------------
1 file changed, 8 insertions(+), 16 deletions(-)
diff --git a/drivers/iio/light/vcnl4000.c b/drivers/iio/light/vcnl4000.c
index 4dbb2294a843..55e5060ce337 100644
--- a/drivers/iio/light/vcnl4000.c
+++ b/drivers/iio/light/vcnl4000.c
@@ -25,6 +25,7 @@
#include <linux/pm_runtime.h>
#include <linux/interrupt.h>
#include <linux/units.h>
+#include <linux/cleanup.h>
#include <linux/iio/buffer.h>
#include <linux/iio/events.h>
@@ -1148,36 +1149,27 @@ static int vcnl4010_write_raw(struct iio_dev *indio_dev,
struct iio_chan_spec const *chan,
int val, int val2, long mask)
{
- int ret;
struct vcnl4000_data *data = iio_priv(indio_dev);
- if (!iio_device_claim_direct(indio_dev))
+ ACQUIRE(iio_device_claim_direct, busy)(indio_dev);
+ if (ACQUIRE_ERR(iio_device_claim_direct, &busy))
return -EBUSY;
/* Protect against event capture. */
- if (vcnl4010_is_in_periodic_mode(data)) {
- ret = -EBUSY;
- goto end;
- }
+ if (vcnl4010_is_in_periodic_mode(data))
+ return -EBUSY;
switch (mask) {
case IIO_CHAN_INFO_SAMP_FREQ:
switch (chan->type) {
case IIO_PROXIMITY:
- ret = vcnl4010_write_proxy_samp_freq(data, val, val2);
- goto end;
+ return vcnl4010_write_proxy_samp_freq(data, val, val2);
default:
- ret = -EINVAL;
- goto end;
+ return -EINVAL;
}
default:
- ret = -EINVAL;
- goto end;
+ return -EINVAL;
}
-
-end:
- iio_device_release_direct(indio_dev);
- return ret;
}
static int vcnl4010_read_event(struct iio_dev *indio_dev,
--
2.52.0
next prev parent reply other threads:[~2025-12-03 19:19 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-03 19:18 [PATCH RFC 0/6] iio: core: Introduce cleanup.h support for mode locks Kurt Borja
2025-12-03 19:18 ` [PATCH RFC 1/6] iio: core: Match iio_device_claim_*() return semantics Kurt Borja
2025-12-04 14:23 ` Nuno Sá
2025-12-04 15:05 ` Andy Shevchenko
2025-12-06 18:07 ` Jonathan Cameron
2025-12-04 17:27 ` Kurt Borja
2025-12-06 18:05 ` Jonathan Cameron
2025-12-07 15:59 ` Kurt Borja
2025-12-03 19:18 ` [PATCH RFC 2/6] iio: core: Match iio_device_claim_*() naming Kurt Borja
2025-12-03 21:50 ` David Lechner
2025-12-04 17:35 ` Kurt Borja
2025-12-06 18:11 ` Jonathan Cameron
2025-12-03 19:18 ` [PATCH RFC 3/6] iio: core: Add cleanup.h support for iio_device_claim_*() Kurt Borja
2025-12-03 21:50 ` David Lechner
2025-12-03 22:34 ` David Lechner
2025-12-04 17:18 ` Kurt Borja
2025-12-04 17:36 ` Andy Shevchenko
2025-12-06 18:43 ` Jonathan Cameron
2025-12-06 20:40 ` Andy Shevchenko
2025-12-07 16:00 ` Kurt Borja
2025-12-06 18:20 ` Jonathan Cameron
2025-12-07 15:59 ` Kurt Borja
2025-12-03 19:18 ` Kurt Borja [this message]
2025-12-03 22:19 ` [PATCH RFC 4/6] iio: light: vcnl4000: Use cleanup.h for IIO locks David Lechner
2025-12-03 19:18 ` [PATCH RFC 5/6] iio: health: max30102: " Kurt Borja
2025-12-03 21:52 ` David Lechner
2025-12-04 17:07 ` Kurt Borja
2025-12-04 17:35 ` David Lechner
2025-12-04 17:47 ` Kurt Borja
2025-12-06 18:17 ` Jonathan Cameron
2025-12-07 15:59 ` Kurt Borja
2025-12-03 19:18 ` [PATCH RFC 6/6] iio: light: opt4060: " Kurt Borja
2025-12-03 22:40 ` David Lechner
2025-12-04 17:23 ` Kurt Borja
2025-12-04 14:42 ` Nuno Sá
2025-12-04 17:31 ` Kurt Borja
2025-12-04 14:36 ` [PATCH RFC 0/6] iio: core: Introduce cleanup.h support for mode locks Nuno Sá
2025-12-04 15:07 ` Andy Shevchenko
2025-12-06 18:46 ` Jonathan Cameron
2025-12-07 16:00 ` Kurt Borja
2025-12-09 10:34 ` Nuno Sá
2025-12-09 17:05 ` David Lechner
2025-12-10 9:17 ` Nuno Sá
2025-12-10 18:04 ` Jonathan Cameron
2025-12-04 17:33 ` Kurt Borja
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20251203-lock-impr-v1-4-b4a1fd639423@gmail.com \
--to=kuurtb@gmail.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dlechner@baylibre.com \
--cc=groeck@chromium.org \
--cc=gwendal@chromium.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=perdaniel.olsson@axis.com \
--cc=raskar.shree97@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox