From: Jonathan Cameron <jic23@kernel.org>
To: David Lechner <dlechner@baylibre.com>
Cc: "Cosmin-Gabriel Tanislav"
<cosmin-gabriel.tanislav.xa@renesas.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: ABI: fix current_trigger description
Date: Thu, 5 Feb 2026 20:03:40 +0000 [thread overview]
Message-ID: <20260205200340.0f343ceb@jic23-huawei> (raw)
In-Reply-To: <db6c8834-7236-429a-bbf3-27c699f69470@baylibre.com>
On Wed, 4 Feb 2026 13:55:33 -0600
David Lechner <dlechner@baylibre.com> wrote:
> On 2/4/26 1:50 PM, Cosmin-Gabriel Tanislav wrote:
> >> From: David Lechner <dlechner@baylibre.com>
> >> Sent: Wednesday, February 4, 2026 9:44 PM
> >>
> >> On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
> >>> Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
> >>> /sys/class/iio does not even exist. Use the current path.
> >>>
> >>> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> >>> ---
> >>> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> >>> index 5f87dcee78f7..4fc9f6bd4281 100644
> >>> --- a/Documentation/ABI/testing/sysfs-bus-iio
> >>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> >>> @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
> >>> Contact: linux-iio@vger.kernel.org
> >>> Description:
> >>> The name of the trigger source being used, as per string given
> >>> - in /sys/class/iio/triggerY/name.
> >>> + in /sys/bus/iio/devices/triggerY/name.
> >>
> >> While we are fixing this, the docs refer to it as triggerX rather than
> >> triggerY.
> >>
> >
> > While I do agree that triggerX would match the definition inside
> > Documentation/ABI/testing/sysfs-bus-iio-trigger-sysfs, I think
> > triggerY is the correct name here, because iio:deviceX is used
> > right above. If we were to use triggerX, it would leave the
> > impression that the X from deviceX and the X from triggerX are the
> > same value.
> >
> Fair point.
>
Agreed and applied.
Thanks,
Jonathan
prev parent reply other threads:[~2026-02-05 20:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 18:02 [PATCH] iio: ABI: fix current_trigger description Cosmin Tanislav
2026-02-04 19:44 ` David Lechner
2026-02-04 19:50 ` Cosmin-Gabriel Tanislav
2026-02-04 19:55 ` David Lechner
2026-02-05 20:03 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260205200340.0f343ceb@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=cosmin-gabriel.tanislav.xa@renesas.com \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox