* [PATCH] iio: ABI: fix current_trigger description
@ 2026-02-04 18:02 Cosmin Tanislav
2026-02-04 19:44 ` David Lechner
0 siblings, 1 reply; 5+ messages in thread
From: Cosmin Tanislav @ 2026-02-04 18:02 UTC (permalink / raw)
To: Jonathan Cameron, David Lechner, Nuno Sá, Andy Shevchenko
Cc: linux-iio, linux-kernel, Cosmin Tanislav
Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
/sys/class/iio does not even exist. Use the current path.
Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
---
Documentation/ABI/testing/sysfs-bus-iio | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
index 5f87dcee78f7..4fc9f6bd4281 100644
--- a/Documentation/ABI/testing/sysfs-bus-iio
+++ b/Documentation/ABI/testing/sysfs-bus-iio
@@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
Contact: linux-iio@vger.kernel.org
Description:
The name of the trigger source being used, as per string given
- in /sys/class/iio/triggerY/name.
+ in /sys/bus/iio/devices/triggerY/name.
What: /sys/bus/iio/devices/iio:deviceX/bufferY/length
KernelVersion: 5.11
--
2.52.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: ABI: fix current_trigger description
2026-02-04 18:02 [PATCH] iio: ABI: fix current_trigger description Cosmin Tanislav
@ 2026-02-04 19:44 ` David Lechner
2026-02-04 19:50 ` Cosmin-Gabriel Tanislav
0 siblings, 1 reply; 5+ messages in thread
From: David Lechner @ 2026-02-04 19:44 UTC (permalink / raw)
To: Cosmin Tanislav, Jonathan Cameron, Nuno Sá, Andy Shevchenko
Cc: linux-iio, linux-kernel
On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
> Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
> /sys/class/iio does not even exist. Use the current path.
>
> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> ---
> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> index 5f87dcee78f7..4fc9f6bd4281 100644
> --- a/Documentation/ABI/testing/sysfs-bus-iio
> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
> Contact: linux-iio@vger.kernel.org
> Description:
> The name of the trigger source being used, as per string given
> - in /sys/class/iio/triggerY/name.
> + in /sys/bus/iio/devices/triggerY/name.
While we are fixing this, the docs refer to it as triggerX rather than
triggerY.
/sys/bus/iio/devices/triggerX is documented, but
/sys/bus/iio/devices/triggerY/name actually seems to be missing. That is
for another patch though.
>
> What: /sys/bus/iio/devices/iio:deviceX/bufferY/length
> KernelVersion: 5.11
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] iio: ABI: fix current_trigger description
2026-02-04 19:44 ` David Lechner
@ 2026-02-04 19:50 ` Cosmin-Gabriel Tanislav
2026-02-04 19:55 ` David Lechner
0 siblings, 1 reply; 5+ messages in thread
From: Cosmin-Gabriel Tanislav @ 2026-02-04 19:50 UTC (permalink / raw)
To: David Lechner, Jonathan Cameron, Nuno Sá, Andy Shevchenko
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
> From: David Lechner <dlechner@baylibre.com>
> Sent: Wednesday, February 4, 2026 9:44 PM
>
> On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
> > Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
> > /sys/class/iio does not even exist. Use the current path.
> >
> > Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> > ---
> > Documentation/ABI/testing/sysfs-bus-iio | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> > index 5f87dcee78f7..4fc9f6bd4281 100644
> > --- a/Documentation/ABI/testing/sysfs-bus-iio
> > +++ b/Documentation/ABI/testing/sysfs-bus-iio
> > @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
> > Contact: linux-iio@vger.kernel.org
> > Description:
> > The name of the trigger source being used, as per string given
> > - in /sys/class/iio/triggerY/name.
> > + in /sys/bus/iio/devices/triggerY/name.
>
> While we are fixing this, the docs refer to it as triggerX rather than
> triggerY.
>
While I do agree that triggerX would match the definition inside
Documentation/ABI/testing/sysfs-bus-iio-trigger-sysfs, I think
triggerY is the correct name here, because iio:deviceX is used
right above. If we were to use triggerX, it would leave the
impression that the X from deviceX and the X from triggerX are the
same value.
> /sys/bus/iio/devices/triggerX is documented, but
> /sys/bus/iio/devices/triggerY/name actually seems to be missing. That is
> for another patch though.
>
> >
> > What: /sys/bus/iio/devices/iio:deviceX/bufferY/length
> > KernelVersion: 5.11
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: ABI: fix current_trigger description
2026-02-04 19:50 ` Cosmin-Gabriel Tanislav
@ 2026-02-04 19:55 ` David Lechner
2026-02-05 20:03 ` Jonathan Cameron
0 siblings, 1 reply; 5+ messages in thread
From: David Lechner @ 2026-02-04 19:55 UTC (permalink / raw)
To: Cosmin-Gabriel Tanislav, Jonathan Cameron, Nuno Sá,
Andy Shevchenko
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
On 2/4/26 1:50 PM, Cosmin-Gabriel Tanislav wrote:
>> From: David Lechner <dlechner@baylibre.com>
>> Sent: Wednesday, February 4, 2026 9:44 PM
>>
>> On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
>>> Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
>>> /sys/class/iio does not even exist. Use the current path.
>>>
>>> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
>>> ---
>>> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
>>> index 5f87dcee78f7..4fc9f6bd4281 100644
>>> --- a/Documentation/ABI/testing/sysfs-bus-iio
>>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
>>> @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
>>> Contact: linux-iio@vger.kernel.org
>>> Description:
>>> The name of the trigger source being used, as per string given
>>> - in /sys/class/iio/triggerY/name.
>>> + in /sys/bus/iio/devices/triggerY/name.
>>
>> While we are fixing this, the docs refer to it as triggerX rather than
>> triggerY.
>>
>
> While I do agree that triggerX would match the definition inside
> Documentation/ABI/testing/sysfs-bus-iio-trigger-sysfs, I think
> triggerY is the correct name here, because iio:deviceX is used
> right above. If we were to use triggerX, it would leave the
> impression that the X from deviceX and the X from triggerX are the
> same value.
>
Fair point.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] iio: ABI: fix current_trigger description
2026-02-04 19:55 ` David Lechner
@ 2026-02-05 20:03 ` Jonathan Cameron
0 siblings, 0 replies; 5+ messages in thread
From: Jonathan Cameron @ 2026-02-05 20:03 UTC (permalink / raw)
To: David Lechner
Cc: Cosmin-Gabriel Tanislav, Nuno Sá, Andy Shevchenko,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
On Wed, 4 Feb 2026 13:55:33 -0600
David Lechner <dlechner@baylibre.com> wrote:
> On 2/4/26 1:50 PM, Cosmin-Gabriel Tanislav wrote:
> >> From: David Lechner <dlechner@baylibre.com>
> >> Sent: Wednesday, February 4, 2026 9:44 PM
> >>
> >> On 2/4/26 12:02 PM, Cosmin Tanislav wrote:
> >>> Triggers exist under /sys/bus/iio/devices/, not under /sys/class/iio.
> >>> /sys/class/iio does not even exist. Use the current path.
> >>>
> >>> Signed-off-by: Cosmin Tanislav <cosmin-gabriel.tanislav.xa@renesas.com>
> >>> ---
> >>> Documentation/ABI/testing/sysfs-bus-iio | 2 +-
> >>> 1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/Documentation/ABI/testing/sysfs-bus-iio b/Documentation/ABI/testing/sysfs-bus-iio
> >>> index 5f87dcee78f7..4fc9f6bd4281 100644
> >>> --- a/Documentation/ABI/testing/sysfs-bus-iio
> >>> +++ b/Documentation/ABI/testing/sysfs-bus-iio
> >>> @@ -1428,7 +1428,7 @@ KernelVersion: 2.6.35
> >>> Contact: linux-iio@vger.kernel.org
> >>> Description:
> >>> The name of the trigger source being used, as per string given
> >>> - in /sys/class/iio/triggerY/name.
> >>> + in /sys/bus/iio/devices/triggerY/name.
> >>
> >> While we are fixing this, the docs refer to it as triggerX rather than
> >> triggerY.
> >>
> >
> > While I do agree that triggerX would match the definition inside
> > Documentation/ABI/testing/sysfs-bus-iio-trigger-sysfs, I think
> > triggerY is the correct name here, because iio:deviceX is used
> > right above. If we were to use triggerX, it would leave the
> > impression that the X from deviceX and the X from triggerX are the
> > same value.
> >
> Fair point.
>
Agreed and applied.
Thanks,
Jonathan
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2026-02-05 20:03 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-04 18:02 [PATCH] iio: ABI: fix current_trigger description Cosmin Tanislav
2026-02-04 19:44 ` David Lechner
2026-02-04 19:50 ` Cosmin-Gabriel Tanislav
2026-02-04 19:55 ` David Lechner
2026-02-05 20:03 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox