Linux IIO development
 help / color / mirror / Atom feed
From: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
To: Jonathan Cameron <jic23@kernel.org>,
	David Lechner <dlechner@baylibre.com>,
	Nuno Sa <nuno.sa@analog.com>, Andy Shevchenko <andy@kernel.org>,
	Michal Simek <michal.simek@amd.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: <linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<linux-kernel@vger.kernel.org>, <saikrishna12468@gmail.com>,
	<git@amd.com>,
	Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
Subject: [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure
Date: Fri, 20 Feb 2026 11:09:38 +0530	[thread overview]
Message-ID: <20260220053941.611415-3-sai.krishna.potthuri@amd.com> (raw)
In-Reply-To: <20260220053941.611415-1-sai.krishna.potthuri@amd.com>

Add setup_channels function pointer to xadc_ops structure to enable
different interfaces to have custom channel setup logic.

Signed-off-by: Sai Krishna Potthuri <sai.krishna.potthuri@amd.com>
---
 drivers/iio/adc/xilinx-xadc-core.c | 8 +++++++-
 drivers/iio/adc/xilinx-xadc.h      | 1 +
 2 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c
index 52b51821007d..ee58b4a80f34 100644
--- a/drivers/iio/adc/xilinx-xadc-core.c
+++ b/drivers/iio/adc/xilinx-xadc-core.c
@@ -35,6 +35,8 @@
 
 #include "xilinx-xadc.h"
 
+static int xadc_parse_dt(struct iio_dev *indio_dev, unsigned int *conf, int irq);
+
 static const unsigned int XADC_ZYNQ_UNMASK_TIMEOUT = 500;
 
 /* ZYNQ register definitions */
@@ -455,6 +457,7 @@ static const struct xadc_ops xadc_zynq_ops = {
 	.get_dclk_rate = xadc_zynq_get_dclk_rate,
 	.interrupt_handler = xadc_zynq_interrupt_handler,
 	.update_alarm = xadc_zynq_update_alarm,
+	.setup_channels = xadc_parse_dt,
 	.type = XADC_TYPE_S7,
 	/* Temp in C = (val * 503.975) / 2**bits - 273.15 */
 	.temp_scale = 503975,
@@ -567,6 +570,7 @@ static const struct xadc_ops xadc_7s_axi_ops = {
 	.get_dclk_rate = xadc_axi_get_dclk,
 	.update_alarm = xadc_axi_update_alarm,
 	.interrupt_handler = xadc_axi_interrupt_handler,
+	.setup_channels = xadc_parse_dt,
 	.flags = XADC_FLAGS_BUFFERED | XADC_FLAGS_IRQ_OPTIONAL,
 	.type = XADC_TYPE_S7,
 	/* Temp in C = (val * 503.975) / 2**bits - 273.15 */
@@ -581,6 +585,7 @@ static const struct xadc_ops xadc_us_axi_ops = {
 	.get_dclk_rate = xadc_axi_get_dclk,
 	.update_alarm = xadc_axi_update_alarm,
 	.interrupt_handler = xadc_axi_interrupt_handler,
+	.setup_channels = xadc_parse_dt,
 	.flags = XADC_FLAGS_BUFFERED | XADC_FLAGS_IRQ_OPTIONAL,
 	.type = XADC_TYPE_US,
 	/**
@@ -1333,9 +1338,10 @@ static struct iio_dev *xadc_device_setup(struct device *dev, int size,
 static int xadc_device_configure(struct device *dev, struct iio_dev *indio_dev,
 				 int irq, unsigned int *conf0, unsigned int *bipolar_mask)
 {
+	struct xadc *xadc = iio_priv(indio_dev);
 	int ret, i;
 
-	ret = xadc_parse_dt(indio_dev, conf0, irq);
+	ret = xadc->ops->setup_channels(indio_dev, conf0, irq);
 	if (ret)
 		return ret;
 
diff --git a/drivers/iio/adc/xilinx-xadc.h b/drivers/iio/adc/xilinx-xadc.h
index b4d9d4683117..26cd65153176 100644
--- a/drivers/iio/adc/xilinx-xadc.h
+++ b/drivers/iio/adc/xilinx-xadc.h
@@ -82,6 +82,7 @@ struct xadc_ops {
 	void (*update_alarm)(struct xadc *xadc, unsigned int alarm);
 	unsigned long (*get_dclk_rate)(struct xadc *xadc);
 	irqreturn_t (*interrupt_handler)(int irq, void *devid);
+	int (*setup_channels)(struct iio_dev *indio_dev, unsigned int *conf, int irq);
 
 	unsigned int flags;
 	enum xadc_type type;
-- 
2.25.1


  parent reply	other threads:[~2026-02-20  5:40 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-20  5:39 [PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard Sai Krishna Potthuri
2026-02-20  5:39 ` [PATCH 1/5] iio: adc: xilinx-xadc: Add helper functions for the device setup Sai Krishna Potthuri
2026-02-20  7:50   ` Andy Shevchenko
2026-02-20  5:39 ` Sai Krishna Potthuri [this message]
2026-02-20  7:52   ` [PATCH 2/5] iio: adc: xilinx-xadc: Add setup_channels function pointer to ops structure Andy Shevchenko
2026-02-20  5:39 ` [PATCH 3/5] iio: adc: xilinx-xadc: Replace module macro with custom init/exit functions Sai Krishna Potthuri
2026-02-20  7:52   ` Andy Shevchenko
2026-02-20  7:54     ` Michal Simek
2026-02-20  8:09       ` Andy Shevchenko
2026-03-18  9:13         ` Sai Krishna Potthuri
2026-03-18  9:46           ` Andy Shevchenko
2026-02-20  5:39 ` [PATCH 4/5] iio: adc: xilinx-xadc: Add I2C interface support Sai Krishna Potthuri
2026-02-20  7:58   ` Andy Shevchenko
2026-02-20  5:39 ` [PATCH 5/5] dt-bindings: iio: adc: xilinx-xadc: convert to YAML format Sai Krishna Potthuri
2026-02-21 10:38   ` Krzysztof Kozlowski
2026-03-19 13:52     ` Sai Krishna Potthuri
2026-03-19 14:23       ` David Lechner
2026-03-19 14:49         ` Sai Krishna Potthuri
2026-03-19 14:58           ` David Lechner
2026-03-19 15:10             ` Sai Krishna Potthuri
2026-03-19 15:35               ` David Lechner
2026-03-19 15:49                 ` Sai Krishna Potthuri
2026-03-19 16:49                   ` Krzysztof Kozlowski
2026-03-19 19:07                     ` David Lechner
2026-03-22  9:55                       ` Krzysztof Kozlowski
2026-02-21 10:39   ` Krzysztof Kozlowski
2026-02-20  8:00 ` [PATCH 0/5] iio: adc: xilinx-xadc: Add I2C interface support for System Management Wizard Andy Shevchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260220053941.611415-3-sai.krishna.potthuri@amd.com \
    --to=sai.krishna.potthuri@amd.com \
    --cc=andy@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=git@amd.com \
    --cc=jic23@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@amd.com \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    --cc=saikrishna12468@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox