Re: [PATCH v3 0/2] iio: dac: m62332: Use guard(mutex) for locking

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 18 Apr 2026 10:03:20 -0300
Erick Henrique <erick.henrique.rodrigues@usp.br> wrote:

> This series refactors the m62332 driver to use guard(mutex) for
> simpler locking, preceded by a header cleanup as suggested by
> Andy Shevchenko.
> 
> Patch 1 applies IWYU to the header block, removes unused slab.h,
> and sorts the includes alphabetically.
> 
> Patch 2 replaces mutex_lock()/mutex_unlock() pairs with guard(mutex)
> and simplifies i2c_master_send() error handling. This patch also
> adds <linux/cleanup.h> which is required by the guard() macro.
> 
> Changes since v2:
> - Split into a two-patch series per Andy's suggestion
> - Added missing <linux/cleanup.h> include
> - Cleaned up header block (IWYU, alphabetical order)
> 
> Changes since v1:
> - Split combined condition in i2c_master_send() error handling
>   into two separate early returns
> 
> Signed-off-by: Erick Henrique <erick.henrique.rodrigues@usp.br>
> 
> Erick Henrique (2):
>   iio: dac: m62332: Clean up header includes
>   iio: dac: m62332: Use guard(mutex) for locking
> 
>  drivers/iio/dac/m62332.c | 31 +++++++++++++++----------------
>  1 file changed, 15 insertions(+), 16 deletions(-)
> 
Hi Erick,

A process comment.  Don't send new versions with the reply-to set.
They should be new threads not burried under an earlier discussion.
Combination of naming and version numbers is enough to associate
the versions though a nice convention is to also include a link
to the lore.kernel.org archive for the previous version.

One practical reason for this is many reviewers and maintainers
tend to catch up with their backlog starting with the latest
email threads (as often earlier versions have been superceeded!)
So I only found this 'in order' because I'm using patch work
as well for tracking purposes.

Thanks

Jonathan