Re: [PATCH v3 1/2] iio: dac: m62332: Clean up header includes

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 18 Apr 2026 10:03:21 -0300
Erick Henrique <erick.henrique.rodrigues@usp.br> wrote:

> Follow IWYU principle: explicitly include headers for symbols used
> in this file, remove unused slab.h, and sort alphabetically.
> 
> This prepares the driver for adding new functionality that requires
> additional headers.
> 
> Signed-off-by: Erick Henrique <erick.henrique.rodrigues@usp.br>
Hi Erick,

A few comments inline.

Thanks!

Jonathan

> ---
>  drivers/iio/dac/m62332.c | 13 +++++++++----
>  1 file changed, 9 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/iio/dac/m62332.c b/drivers/iio/dac/m62332.c
> index 3497513854d7..4b139904e818 100644
> --- a/drivers/iio/dac/m62332.c
> +++ b/drivers/iio/dac/m62332.c
> @@ -8,13 +8,18 @@
>   *  Copyright (C) 2010, 2011 Roland Stigge <stigge@antcom.de>
>   */
>  
> -#include <linux/module.h>
> -#include <linux/slab.h>
> -#include <linux/i2c.h>

Resorting and new includes in one go does make it harder to see what
is done. Generally I'd prefer that as two patches when we have more than 
a very small number of includes. Sort first, then add / remove headers
as needed.

> +#include <linux/array_size.h>
> +#include <linux/bits.h>
> +#include <linux/device.h>
This is one of the more complex corners of applying IWYU to kernel code.
device.h is a bit of a legacy 'catch all' and much like kernel.h the
general direction of travel is to include more specific headers instead.

You probably need a forwards definition of
struct device;
just after the includes however as the pointer type is used.
I'm not immediately spotting any other use of device.h rather various
more specific headers but I might be missing it.

>  #include <linux/err.h>
> +#include <linux/i2c.h>
> +#include <linux/module.h>

I'd expect to see
mod_devicetable.h in pretty much any IIO driver as that's where the ID
tables are coming from.

> +#include <linux/mutex.h>
> +#include <linux/pm.h>
> +#include <linux/types.h>
>  
> -#include <linux/iio/iio.h>
>  #include <linux/iio/driver.h>
> +#include <linux/iio/iio.h>
>  
>  #include <linux/regulator/consumer.h>
>