[PATCH v2 0/1] iio: chemical: bme680: use BME680_NUM_CHANNELS

[PATCH v2 0/1] iio: chemical: bme680: use BME680_NUM_CHANNELS

[Nikhil Gautam]

Hi,

This patch updates the BME680 driver to use the existing
BME680_NUM_CHANNELS macro instead of a hardcoded value in the
scan buffer.

In the previous version, the macro was proposed for removal as it
appeared unused. However, it was pointed out during review that
it is intended to represent the number of channels in the scan
buffer.

This version addresses that feedback by using the macro instead
of removing it, improving readability and maintainability.

Changes in v2:

Use BME680_NUM_CHANNELS instead of hardcoded value
Keep the macro instead of removing it
Address review feedback from Jonathan Cameron

Suggested-by: Jonathan Cameron <jic23@kernel.org>

Thanks,
Nikhil Gautam

Nikhil Gautam (1):
  iio: chemical: bme680: use BME680_NUM_CHANNELS for scan buffer

 drivers/iio/chemical/bme680_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.34.1

[PATCH v2 1/1] iio: chemical: bme680: use BME680_NUM_CHANNELS for scan buffer

[Nikhil Gautam]

Use BME680_NUM_CHANNELS instead of the hardcoded channel count
in the scan buffer.

This avoids use of a magic number and improves code readability
and maintainability.

Suggested-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Nikhil Gautam <nikhilgtr@gmail.com>
---
 drivers/iio/chemical/bme680_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/chemical/bme680_core.c b/drivers/iio/chemical/bme680_core.c
index 3e850562ab00..42c1a9de175a 100644
--- a/drivers/iio/chemical/bme680_core.c
+++ b/drivers/iio/chemical/bme680_core.c
@@ -128,7 +128,7 @@ struct bme680_data {
 	u16 heater_temp;
 
 	struct {
-		s32 chan[4];
+		s32 chan[BME680_NUM_CHANNELS];
 		aligned_s64 ts;
 	} scan;
 
-- 
2.34.1