public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Ariana Lazar <ariana.lazar@microchip.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"Rob Herring" <robh@kernel.org>,
	"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Jonathan Cameron" <Jonathan.Cameron@huawei.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
Date: Mon, 20 Apr 2026 13:22:48 +0100	[thread overview]
Message-ID: <20260420132248.466cdc84@jic23-huawei> (raw)
In-Reply-To: <20260420-mcp47feb02-fix6-v1-1-ae1808fea11d@microchip.com>

On Mon, 20 Apr 2026 13:36:02 +0300
Ariana Lazar <ariana.lazar@microchip.com> wrote:

> Change example reg value from 0 to 0x60 in order to use a valid I2C address
> 
> Fixes: 4ba12d304175 ("dt-bindings: iio: dac: adding support for Microchip MCP47FEB02")
> Link: https://lore.kernel.org/all/dd0dbadb-604b-4f12-8674-268b7db096fd@baylibre.com/
> Signed-off-by: Ariana Lazar <ariana.lazar@microchip.com>
> ---
>  .../bindings/iio/dac/microchip,mcp47feb02.yaml     | 32 +++++++++++-----------
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> index d2466aa6bda2106a8b695347a0edf38462294d03..95ddc8321eff34ed27dab8ce712210d2cb9ae785 100644
> --- a/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> +++ b/Documentation/devicetree/bindings/iio/dac/microchip,mcp47feb02.yaml
> @@ -280,23 +280,23 @@ examples:
>  
>          #address-cells = <1>;
>          #size-cells = <0>;
> -        dac@0 {
> -          compatible = "microchip,mcp47feb02";
> -          reg = <0>;
> -          vdd-supply = <&vdac_vdd>;
> -          vref-supply = <&vref_reg>;
> +        dac@60 {
> +            compatible = "microchip,mcp47feb02";
Why is this indent changing?

> +            reg = <0x60>;
> +            vdd-supply = <&vdac_vdd>;
> +            vref-supply = <&vref_reg>;
>  
> -          #address-cells = <1>;
> -          #size-cells = <0>;
> -          channel@0 {
> -            reg = <0>;
> -            label = "Adjustable_voltage_ch0";
> -          };
> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +            channel@0 {
> +                reg = <0>;
> +                label = "Adjustable_voltage_ch0";
> +            };
>  
> -          channel@1 {
> -            reg = <0x1>;
> -            label = "Adjustable_voltage_ch1";
> -          };
> -      };
> +            channel@1 {
> +                reg = <0x1>;
> +                label = "Adjustable_voltage_ch1";
> +            };
> +        };
>      };
>  ...
> 
> ---
> base-commit: d2a4ec19d2a2e54c23b5180e939994d3da4a6b91
> change-id: 20260417-mcp47feb02-fix6-bd6694d84750
> 
> Best regards,


  reply	other threads:[~2026-04-20 12:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 10:36 [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
2026-04-20 12:22 ` Jonathan Cameron [this message]
2026-04-21 14:09   ` Ariana.Lazar
2026-04-21 15:01     ` Jonathan Cameron
2026-04-20 12:29 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260420132248.466cdc84@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=andy@kernel.org \
    --cc=ariana.lazar@microchip.com \
    --cc=conor+dt@kernel.org \
    --cc=conor.dooley@microchip.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox