From: Jonathan Cameron <jic23@kernel.org>
To: <Ariana.Lazar@microchip.com>
Cc: <dlechner@baylibre.com>, <nuno.sa@analog.com>,
<Conor.Dooley@microchip.com>, <Jonathan.Cameron@huawei.com>,
<robh@kernel.org>, <linux-iio@vger.kernel.org>, <andy@kernel.org>,
<krzk+dt@kernel.org>, <linux-kernel@vger.kernel.org>,
<conor+dt@kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example
Date: Tue, 21 Apr 2026 16:01:26 +0100 [thread overview]
Message-ID: <20260421160126.03a410f5@jic23-huawei> (raw)
In-Reply-To: <3b12b49f8dfa8bbdd4d19eed8718a2f10a294ecf.camel@microchip.com>
On Tue, 21 Apr 2026 14:09:48 +0000
<Ariana.Lazar@microchip.com> wrote:
> Hello Jonathan,
>
> > > @@ -280,23 +280,23 @@ examples:
> > >
> > > #address-cells = <1>;
> > > #size-cells = <0>;
> > > - dac@0 {
> > > - compatible = "microchip,mcp47feb02";
> > > - reg = <0>;
> > > - vdd-supply = <&vdac_vdd>;
> > > - vref-supply = <&vref_reg>;
> > > + dac@60 {
> > > + compatible = "microchip,mcp47feb02";
> > Why is this indent changing?
> >
> > > + reg = <0x60>;
> > > + vdd-supply = <&vdac_vdd>;
> > > + vref-supply = <&vref_reg>;
> > >
> > > - #address-cells = <1>;
> > > - #size-cells = <0>;
> > > - channel@0 {
> > > - reg = <0>;
> > > - label = "Adjustable_voltage_ch0";
> > > - };
> > > + #address-cells = <1>;
> > > + #size-cells = <0>;
> > > + channel@0 {
> > > + reg = <0>;
> > > + label = "Adjustable_voltage_ch0";
> > > + };
> > >
> > > - channel@1 {
> > > - reg = <0x1>;
> > > - label = "Adjustable_voltage_ch1";
> > > - };
> > > - };
> > > + channel@1 {
> > > + reg = <0x1>;
> > > + label = "Adjustable_voltage_ch1";
> > > + };
> > > + };
> > > };
> > > ...
> >
>
> Thank you for the review.
>
> 1. I updated the example indentation in order to use consistent 4-
> space indentation, instead of mixing with 2-space as in the
> previous version.
>
If that is needed, two patches. One that makes the address fix, then
a follow up to fix the indentation with no functional changes.
thanks,
Jonathan
> Best regards,
> Ariana
>
next prev parent reply other threads:[~2026-04-21 15:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 10:36 [PATCH] dt-bindings: iio: dac: mcp47feb02: Fix I2C address in example Ariana Lazar
2026-04-20 12:22 ` Jonathan Cameron
2026-04-21 14:09 ` Ariana.Lazar
2026-04-21 15:01 ` Jonathan Cameron [this message]
2026-04-20 12:29 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421160126.03a410f5@jic23-huawei \
--to=jic23@kernel.org \
--cc=Ariana.Lazar@microchip.com \
--cc=Conor.Dooley@microchip.com \
--cc=Jonathan.Cameron@huawei.com \
--cc=andy@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox