public inbox for linux-iio@vger.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
	dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: magnetometer: ak8975: header cleanup
Date: Tue, 21 Apr 2026 11:33:57 +0100	[thread overview]
Message-ID: <20260421113357.17098de8@jic23-huawei> (raw)
In-Reply-To: <CALoEA-za23QHxtjoW5gjT4c60-vPYb5v0AZV+y_odJ1TQrfafA@mail.gmail.com>

On Tue, 21 Apr 2026 08:16:42 +0200
Joshua Crofts <joshua.crofts1@gmail.com> wrote:

> On Mon, 20 Apr 2026 at 19:18, Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> > Seems this implied sorting as well. As Jonathan says somewhere else
> > he prefers to split sorting and IWYU patches.  
> 
> Okay, I'll return it pre-sort.
> 
What I'd prefer is sort, then changes.

That way it's easy to see what is removed or added rather than moved.

Thanks,

Jonathan



  reply	other threads:[~2026-04-21 10:34 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-20 11:08 [PATCH 0/4] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts
2026-04-20 11:08 ` [PATCH 1/4] iio: magnetometer: ak8975: header cleanup Joshua Crofts
2026-04-20 17:18   ` Andy Shevchenko
2026-04-21  6:16     ` Joshua Crofts
2026-04-21 10:33       ` Jonathan Cameron [this message]
2026-04-20 11:08 ` [PATCH 2/4] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts
2026-04-20 17:20   ` Andy Shevchenko
2026-04-20 11:08 ` [PATCH 3/4] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts
2026-04-20 17:23   ` Andy Shevchenko
2026-04-21  6:22     ` Joshua Crofts
2026-04-20 11:08 ` [PATCH 4/4] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts
2026-04-20 17:26   ` Andy Shevchenko
2026-04-21  6:19     ` Joshua Crofts

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260421113357.17098de8@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=joshua.crofts1@gmail.com \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox