From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Joshua Crofts <joshua.crofts1@gmail.com>
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/4] iio: magnetometer: ak8975: header cleanup
Date: Mon, 20 Apr 2026 20:18:43 +0300 [thread overview]
Message-ID: <aeZf8_NszentI8-M@ashevche-desk.local> (raw)
In-Reply-To: <20260420110804.1353-2-joshua.crofts1@gmail.com>
On Mon, Apr 20, 2026 at 11:08:01AM +0000, Joshua Crofts wrote:
> Clean up headers by removing proxy kernel.h header and adding new
> headers to ensure atomicity (array_size.h, dev_printk.h, types.h,
> asm/byteorder.h). Removed unused headers (slab.h, iio/sysfs.h,
> iio/trigger.h) and added minmax.h, property.h, wait.h, irqreturn.h to
> mitigate transient dependencies during compilation.
>
> Audited using the include-what-you-use tool.
Seems this implied sorting as well. As Jonathan says somewhere else
he prefers to split sorting and IWYU patches.
...
> #include <linux/iio/iio.h>
> -#include <linux/iio/sysfs.h>
> #include <linux/iio/buffer.h>
> -#include <linux/iio/trigger.h>
> #include <linux/iio/trigger_consumer.h>
> #include <linux/iio/triggered_buffer.h>
Also note that this group left unsorted.
>
> --
> 2.47.3
>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-04-20 17:18 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 11:08 [PATCH 0/4] iio: magnetometer: ak8975: modernize and cleanup driver Joshua Crofts
2026-04-20 11:08 ` [PATCH 1/4] iio: magnetometer: ak8975: header cleanup Joshua Crofts
2026-04-20 17:18 ` Andy Shevchenko [this message]
2026-04-21 6:16 ` Joshua Crofts
2026-04-21 10:33 ` Jonathan Cameron
2026-04-20 11:08 ` [PATCH 2/4] iio: magnetometer: ak8975: replace usleep_range() with fsleep() Joshua Crofts
2026-04-20 17:20 ` Andy Shevchenko
2026-04-20 11:08 ` [PATCH 3/4] iio: magnetometer: ak8975: change 'u8*' to 'u8 *' in cast Joshua Crofts
2026-04-20 17:23 ` Andy Shevchenko
2026-04-21 6:22 ` Joshua Crofts
2026-04-20 11:08 ` [PATCH 4/4] iio: magnetometer: ak8975: modernize polling loops with iopoll() macros Joshua Crofts
2026-04-20 17:26 ` Andy Shevchenko
2026-04-21 6:19 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aeZf8_NszentI8-M@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox