From: Jonathan Cameron <jic23@kernel.org>
To: Marcelo Machado Lage <marcelomlage@usp.br>
Cc: andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
Vinicius Lira <vinilira@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v3 1/2] iio: adc: mcp3422: rewrite mask macros using bits.h macros
Date: Tue, 21 Apr 2026 16:54:52 +0100 [thread overview]
Message-ID: <20260421165452.76df9b7c@jic23-huawei> (raw)
In-Reply-To: <20260420191455.529923-2-marcelomlage@usp.br>
On Mon, 20 Apr 2026 16:14:54 -0300
Marcelo Machado Lage <marcelomlage@usp.br> wrote:
> Rewrite MCP3422_CHANNEL_MASK, MCP3422_PGA_MASK, MCP3422_PGA_MASK
> and MCP3422_CONT_SAMPLING using GENMASK() and BIT() macros from
> bits.h.
https://sashiko.dev/#/patchset/20260420191455.529923-1-marcelomlage%40usp.br
pointed out repetition of PGA_MASK.
The other comments are a mixed bag but it's worth taking a look to see
if you think any of them matter. They are all really about the existin
code.
>
> The other macros MCP3422_SRATE_{240, 60, 15, 3} were not changed
> because they are also used as array indices.
>
> Signed-off-by: Marcelo Machado Lage <marcelomlage@usp.br>
> Co-developed-by: Vinicius Lira <vinilira@usp.br>
> Signed-off-by: Vinicius Lira <vinilira@usp.br>
next prev parent reply other threads:[~2026-04-21 15:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 19:14 [PATCH v3 0/2] iio: adc: mcp3422: apply bit manipulation macros Marcelo Machado Lage
2026-04-20 19:14 ` [PATCH v3 1/2] iio: adc: mcp3422: rewrite mask macros using bits.h macros Marcelo Machado Lage
2026-04-21 15:54 ` Jonathan Cameron [this message]
2026-04-20 19:14 ` [PATCH v3 2/2] iio: adc: mcp3422: write bit operations with bitfield.h macros Marcelo Machado Lage
2026-04-20 20:24 ` Andy Shevchenko
2026-04-21 14:52 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260421165452.76df9b7c@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=marcelomlage@usp.br \
--cc=nuno.sa@analog.com \
--cc=vinilira@usp.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox