Re: [PATCH v3 1/2] iio: adc: mcp3422: rewrite mask macros using bits.h macros

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Thu, Apr 23, 2026 at 04:15:54PM -0300, Marcelo Machado Lage wrote:

Please, stop top-posting! It's not how we do in Linux kernel mailing lists.


> Thank you for your comments. We will correct the mistake in the commit
> message in the next version of the patch.
> Regarding the comments at
> https://sashiko.dev/#/patchset/20260420191455.529923-1-marcelomlage%40usp.br,
> we appreciate the opportunity to learn about this resource. However,
> after going through the content there, we do not feel confident to
> address other pre-existing issues in the code at the moment.

Also drop the second 'macros' in the Subject or rephrase it.
Exempli gratia: 'rewrite mask macros with help of bits.h APIs'.

> Em ter., 21 de abr. de 2026 às 12:55, Jonathan Cameron
> <jic23@kernel.org> escreveu:
> >
> > On Mon, 20 Apr 2026 16:14:54 -0300
> > Marcelo Machado Lage <marcelomlage@usp.br> wrote:
> >
> > > Rewrite MCP3422_CHANNEL_MASK, MCP3422_PGA_MASK, MCP3422_PGA_MASK
> > > and MCP3422_CONT_SAMPLING using GENMASK() and BIT() macros from
> > > bits.h.
> > https://sashiko.dev/#/patchset/20260420191455.529923-1-marcelomlage%40usp.br
> > pointed out repetition of PGA_MASK.
> >
> > The other comments are a mixed bag but it's worth taking a look to see
> > if you think any of them matter.  They are all really about the existin
> > code.

> > > The other macros MCP3422_SRATE_{240, 60, 15, 3} were not changed
> > > because they are also used as array indices.

-- 
With Best Regards,
Andy Shevchenko