Re: [PATCH 01/10] iio: dac: ad5686: refactor include headers

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 26 Apr 2026 09:38:02 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:

> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
> 
> Apply IWYU principle, replacing unused/generic headers for
> specific/missing headers. The resulting include directive list is sorted
> accordingly.

As below, I would expect some headers to be included in the c file
even if they are also in the local header.

> 
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
> ---
>  drivers/iio/dac/ad5686-spi.c |  9 +++++++--
>  drivers/iio/dac/ad5686.c     | 13 ++++---------
>  drivers/iio/dac/ad5686.h     |  5 ++---
>  drivers/iio/dac/ad5696-i2c.c | 10 +++++++---
>  4 files changed, 20 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/iio/dac/ad5686-spi.c b/drivers/iio/dac/ad5686-spi.c
> index df8619e0c092..695125238633 100644
> --- a/drivers/iio/dac/ad5686-spi.c
> +++ b/drivers/iio/dac/ad5686-spi.c
> @@ -8,11 +8,16 @@
>   * Copyright 2018 Analog Devices Inc.
>   */
>  
> -#include "ad5686.h"
> -
> +#include <linux/array_size.h>
> +#include <linux/err.h>
> +#include <linux/mod_devicetable.h>
>  #include <linux/module.h>
>  #include <linux/spi/spi.h>
>  
> +#include <asm/byteorder.h>
> +
> +#include "ad5686.h"
> +
>  static int ad5686_spi_write(struct ad5686_state *st,
>  			    u8 cmd, u8 addr, u16 val)
>  {
> diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
> index 9a384c50929b..1a6eb3832f22 100644
> --- a/drivers/iio/dac/ad5686.c
> +++ b/drivers/iio/dac/ad5686.c
> @@ -5,17 +5,12 @@
>   * Copyright 2011 Analog Devices Inc.
>   */
>  
> -#include <linux/interrupt.h>
> -#include <linux/fs.h>
> -#include <linux/device.h>
> +#include <linux/array_size.h>
> +#include <linux/err.h>
> +#include <linux/export.h>
>  #include <linux/module.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
>  #include <linux/regulator/consumer.h>
> -
> -#include <linux/iio/iio.h>

Keep this one in the c files. IWYU does not allow for removing
includes just because they are in another header.  The fact this
one is included in ad5686.h is down to using IIO_DMA_MINALIGN
which is not 'obvious' from point of view of the c files including it.

> -#include <linux/iio/sysfs.h>
> +#include <linux/sysfs.h>
>  
>  #include "ad5686.h"
>  
> diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h
> index e7d36bae3e59..3fcc792ea656 100644
> --- a/drivers/iio/dac/ad5686.h
> +++ b/drivers/iio/dac/ad5686.h
> @@ -8,10 +8,9 @@
>  #ifndef __DRIVERS_IIO_DAC_AD5686_H__
>  #define __DRIVERS_IIO_DAC_AD5686_H__
>  
> -#include <linux/types.h>
> -#include <linux/cache.h>
> +#include <linux/bits.h>
>  #include <linux/mutex.h>
> -#include <linux/kernel.h>
> +#include <linux/types.h>
>  
>  #include <linux/iio/iio.h>

>  
> diff --git a/drivers/iio/dac/ad5696-i2c.c b/drivers/iio/dac/ad5696-i2c.c
> index d3327bca0e07..e7e1b8a6fc71 100644
> --- a/drivers/iio/dac/ad5696-i2c.c
> +++ b/drivers/iio/dac/ad5696-i2c.c
> @@ -7,10 +7,14 @@
>   * Copyright 2018 Analog Devices Inc.
>   */
>  
> -#include "ad5686.h"
> -
> -#include <linux/module.h>
> +#include <linux/err.h>
>  #include <linux/i2c.h>
> +#include <linux/mod_devicetable.h>
> +#include <linux/module.h>
> +
> +#include <asm/byteorder.h>
> +
> +#include "ad5686.h"
>  
>  static int ad5686_i2c_read(struct ad5686_state *st, u8 addr)
>  {
>