From: Jonathan Cameron <jic23@kernel.org>
To: Rodrigo Alencar via B4 Relay
<devnull+rodrigo.alencar.analog.com@kernel.org>
Cc: rodrigo.alencar@analog.com, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@suse.de>,
Michael Auchter <michael.auchter@ni.com>,
Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>
Subject: Re: [PATCH 03/10] iio: dac: ad5686: drop enum id
Date: Sun, 26 Apr 2026 14:35:10 +0100 [thread overview]
Message-ID: <20260426143510.4bcfb6d8@jic23-huawei> (raw)
In-Reply-To: <20260426-ad5686-fixes-v1-3-7c946a77794e@analog.com>
On Sun, 26 Apr 2026 09:38:04 +0100
Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org> wrote:
> From: Rodrigo Alencar <rodrigo.alencar@analog.com>
>
> Split chip info table into separate structs and expose them to the spi
> i2c drivers. That is the preferrable approach and allows for the drivers
> to have knowledge of the device info before the common probe function gets
> called. Those chip info structs may be shared by SPI and I2C driver
> variants.
> Channel declaration definitions are grouped according to channel count and
> DECLARE_AD5693_CHANNELS() macro is renamed to DECLARE_AD5683_CHANNELS() to
> match the regmap_type enum.
> Use spi_get_device_match_data() and i2c_get_match_data() to get chip info
> struct reference, passing it as parameter to the common probe function.
>
> Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
Nice. Given no one had any comments on v1 I'll assume everyone is fine with this
one.
Applied to the testing branch of iio.git.
thanks,
Jonathan
next prev parent reply other threads:[~2026-04-26 13:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-26 8:38 [PATCH 00/10] Fixes and cleanups for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-04-26 8:38 ` [PATCH 01/10] iio: dac: ad5686: refactor include headers Rodrigo Alencar via B4 Relay
2026-04-26 13:29 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 02/10] iio: dac: ad5686: remove redundant register definition Rodrigo Alencar via B4 Relay
2026-04-26 13:32 ` Jonathan Cameron
2026-04-26 13:38 ` Jonathan Cameron
2026-04-27 10:09 ` Rodrigo Alencar
2026-04-27 10:25 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 03/10] iio: dac: ad5686: drop enum id Rodrigo Alencar via B4 Relay
2026-04-26 13:35 ` Jonathan Cameron [this message]
2026-04-26 8:38 ` [PATCH 04/10] iio: dac: ad5686: add of_match table to the spi driver Rodrigo Alencar via B4 Relay
2026-04-26 13:37 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 05/10] iio: dac: ad5686: fix ref bit initialization for single-channel parts Rodrigo Alencar via B4 Relay
2026-04-26 13:44 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 06/10] iio: dac: ad5686: acquire lock when doing powerdown control Rodrigo Alencar via B4 Relay
2026-04-26 13:47 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 07/10] iio: dac: ad5686: fix powerdown control on dual-channel devices Rodrigo Alencar via B4 Relay
2026-04-26 13:48 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 08/10] iio: dac: ad5686: fix input raw value check Rodrigo Alencar via B4 Relay
2026-04-26 13:49 ` Jonathan Cameron
2026-04-26 8:38 ` [PATCH 09/10] iio: dac: ad5686: cleanup doc header of local structs Rodrigo Alencar via B4 Relay
2026-04-26 8:38 ` [PATCH 10/10] iio: dac: ad5686: create bus ops struct Rodrigo Alencar via B4 Relay
2026-04-26 13:50 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260426143510.4bcfb6d8@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=devnull+rodrigo.alencar.analog.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=rodrigo.alencar@analog.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox