From: Rodrigo Alencar via B4 Relay <devnull+rodrigo.alencar.analog.com@kernel.org>
To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Popa <stefan.popa@analog.com>,
Jonathan Cameron <jic23@cam.ac.uk>,
Greg Kroah-Hartman <gregkh@suse.de>,
Michael Auchter <michael.auchter@ni.com>,
Jonathan Cameron <jic23@kernel.org>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Michael Hennerich <Michael.Hennerich@analog.com>,
Jonathan Cameron <jic23@kernel.org>,
David Lechner <dlechner@baylibre.com>,
Andy Shevchenko <andy@kernel.org>,
Rodrigo Alencar <rodrigo.alencar@analog.com>
Subject: [PATCH v3 05/11] iio: dac: ad5686: refactor include headers
Date: Tue, 28 Apr 2026 18:02:20 +0100 [thread overview]
Message-ID: <20260428-ad5686-fixes-v3-5-9cff7bd67a15@analog.com> (raw)
In-Reply-To: <20260428-ad5686-fixes-v3-0-9cff7bd67a15@analog.com>
From: Rodrigo Alencar <rodrigo.alencar@analog.com>
Apply IWYU principle, replacing unused/generic headers for
specific/missing headers. The resulting include directive lists are sorted
accordingly.
Signed-off-by: Rodrigo Alencar <rodrigo.alencar@analog.com>
---
drivers/iio/dac/ad5686-spi.c | 9 +++++++--
drivers/iio/dac/ad5686.c | 11 ++++-------
drivers/iio/dac/ad5686.h | 5 ++---
drivers/iio/dac/ad5696-i2c.c | 10 +++++++---
4 files changed, 20 insertions(+), 15 deletions(-)
diff --git a/drivers/iio/dac/ad5686-spi.c b/drivers/iio/dac/ad5686-spi.c
index df8619e0c092..695125238633 100644
--- a/drivers/iio/dac/ad5686-spi.c
+++ b/drivers/iio/dac/ad5686-spi.c
@@ -8,11 +8,16 @@
* Copyright 2018 Analog Devices Inc.
*/
-#include "ad5686.h"
-
+#include <linux/array_size.h>
+#include <linux/err.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/spi/spi.h>
+#include <asm/byteorder.h>
+
+#include "ad5686.h"
+
static int ad5686_spi_write(struct ad5686_state *st,
u8 cmd, u8 addr, u16 val)
{
diff --git a/drivers/iio/dac/ad5686.c b/drivers/iio/dac/ad5686.c
index b31d0ec5415c..70d61ed29aa8 100644
--- a/drivers/iio/dac/ad5686.c
+++ b/drivers/iio/dac/ad5686.c
@@ -5,17 +5,14 @@
* Copyright 2011 Analog Devices Inc.
*/
-#include <linux/interrupt.h>
-#include <linux/fs.h>
-#include <linux/device.h>
+#include <linux/array_size.h>
+#include <linux/err.h>
+#include <linux/export.h>
#include <linux/module.h>
-#include <linux/kernel.h>
-#include <linux/slab.h>
-#include <linux/sysfs.h>
#include <linux/regulator/consumer.h>
+#include <linux/sysfs.h>
#include <linux/iio/iio.h>
-#include <linux/iio/sysfs.h>
#include "ad5686.h"
diff --git a/drivers/iio/dac/ad5686.h b/drivers/iio/dac/ad5686.h
index 36e16c5c4581..d08160e7fad9 100644
--- a/drivers/iio/dac/ad5686.h
+++ b/drivers/iio/dac/ad5686.h
@@ -8,10 +8,9 @@
#ifndef __DRIVERS_IIO_DAC_AD5686_H__
#define __DRIVERS_IIO_DAC_AD5686_H__
-#include <linux/types.h>
-#include <linux/cache.h>
+#include <linux/bits.h>
#include <linux/mutex.h>
-#include <linux/kernel.h>
+#include <linux/types.h>
#include <linux/iio/iio.h>
diff --git a/drivers/iio/dac/ad5696-i2c.c b/drivers/iio/dac/ad5696-i2c.c
index d3327bca0e07..e7e1b8a6fc71 100644
--- a/drivers/iio/dac/ad5696-i2c.c
+++ b/drivers/iio/dac/ad5696-i2c.c
@@ -7,10 +7,14 @@
* Copyright 2018 Analog Devices Inc.
*/
-#include "ad5686.h"
-
-#include <linux/module.h>
+#include <linux/err.h>
#include <linux/i2c.h>
+#include <linux/mod_devicetable.h>
+#include <linux/module.h>
+
+#include <asm/byteorder.h>
+
+#include "ad5686.h"
static int ad5686_i2c_read(struct ad5686_state *st, u8 addr)
{
--
2.43.0
next prev parent reply other threads:[~2026-04-28 17:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 17:02 [PATCH v3 00/11] Fixes and cleanups for the AD5686 IIO driver Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 01/11] iio: dac: ad5686: fix ref bit initialization for single-channel parts Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 02/11] iio: dac: ad5686: fix input raw value check Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 03/11] iio: dac: ad5686: acquire lock when doing powerdown control Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 04/11] iio: dac: ad5686: fix powerdown control on dual-channel devices Rodrigo Alencar via B4 Relay
2026-04-29 10:07 ` Jonathan Cameron
2026-04-29 10:33 ` Rodrigo Alencar
2026-04-28 17:02 ` Rodrigo Alencar via B4 Relay [this message]
2026-04-29 10:11 ` [PATCH v3 05/11] iio: dac: ad5686: refactor include headers Jonathan Cameron
2026-04-28 17:02 ` [PATCH v3 06/11] iio: dac: ad5686: remove redundant register definition Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 07/11] iio: dac: ad5686: drop enum id Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 08/11] iio: dac: ad5686: add of_match table to the spi driver Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 09/11] iio: dac: ad5686: add control_sync() for single-channel devices Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 10/11] iio: dac: ad5686: cleanup doc header of local structs Rodrigo Alencar via B4 Relay
2026-04-28 17:02 ` [PATCH v3 11/11] iio: dac: ad5686: create bus ops struct Rodrigo Alencar via B4 Relay
2026-04-29 6:36 ` [PATCH v3 00/11] Fixes and cleanups for the AD5686 IIO driver Andy Shevchenko
2026-04-29 9:36 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428-ad5686-fixes-v3-5-9cff7bd67a15@analog.com \
--to=devnull+rodrigo.alencar.analog.com@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@suse.de \
--cc=jic23@cam.ac.uk \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.auchter@ni.com \
--cc=rodrigo.alencar@analog.com \
--cc=stefan.popa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox