From: Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
Joshua Crofts <joshua.crofts1@gmail.com>
Subject: [PATCH v2 2/5] iio: light: si1133: remove unused macros
Date: Tue, 28 Apr 2026 15:18:34 +0200 [thread overview]
Message-ID: <20260428-si1133-checkup-v2-2-70ad14bfefe2@gmail.com> (raw)
In-Reply-To: <20260428-si1133-checkup-v2-0-70ad14bfefe2@gmail.com>
From: Joshua Crofts <joshua.crofts1@gmail.com>
Remove unused macros to improve readability.
No functional change.
Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
---
drivers/iio/light/si1133.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
index 52e4269dc35014b87b7c46a120e64723be716768..ada8da122b76c9a0a55751baa6522a145f0fc7e8 100644
--- a/drivers/iio/light/si1133.c
+++ b/drivers/iio/light/si1133.c
@@ -22,8 +22,6 @@
#define SI1133_REG_PART_ID 0x00
#define SI1133_REG_REV_ID 0x01
#define SI1133_REG_MFR_ID 0x02
-#define SI1133_REG_INFO0 0x03
-#define SI1133_REG_INFO1 0x04
#define SI1133_PART_ID 0x33
@@ -40,7 +38,6 @@
#define SI1133_CMD_RESET_CTR 0x00
#define SI1133_CMD_RESET_SW 0x01
#define SI1133_CMD_FORCE 0x11
-#define SI1133_CMD_START_AUTONOMOUS 0x13
#define SI1133_CMD_PARAM_SET 0x80
#define SI1133_CMD_PARAM_QUERY 0x40
#define SI1133_CMD_PARAM_MASK 0x3F
@@ -86,13 +83,9 @@
#define SI1133_CMD_MINSLEEP_US_LOW 5000
#define SI1133_CMD_MINSLEEP_US_HIGH 7500
#define SI1133_CMD_TIMEOUT_MS 25
-#define SI1133_CMD_LUX_TIMEOUT_MS 5000
-#define SI1133_CMD_TIMEOUT_US (SI1133_CMD_TIMEOUT_MS * 1000)
#define SI1133_REG_HOSTOUT(x) ((x) + 0x13)
-#define SI1133_MEASUREMENT_FREQUENCY 1250
-
#define SI1133_X_ORDER_MASK 0x0070
#define SI1133_Y_ORDER_MASK 0x0007
#define si1133_get_x_order(m) (((m) & SI1133_X_ORDER_MASK) >> 4)
--
2.47.3
next prev parent reply other threads:[~2026-04-28 13:18 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 13:18 [PATCH v2 0/5] iio: light: si1133: driver cleanup Joshua Crofts via B4 Relay
2026-04-28 13:18 ` [PATCH v2 1/5] iio: light: si1133: prefer complex macros enclosed in parenthesis Joshua Crofts via B4 Relay
2026-04-28 13:18 ` Joshua Crofts via B4 Relay [this message]
2026-04-28 15:12 ` [PATCH v2 2/5] iio: light: si1133: remove unused macros Jonathan Cameron
2026-04-28 16:25 ` Joshua Crofts
2026-04-28 13:18 ` [PATCH v2 3/5] iio: light: si1133: add missing include headers Joshua Crofts via B4 Relay
2026-04-28 13:18 ` [PATCH v2 4/5] iio: light: si1133: group generic <linux/*> headers Joshua Crofts via B4 Relay
2026-04-28 15:14 ` Jonathan Cameron
2026-04-28 13:18 ` [PATCH v2 5/5] iio: light: si1133: use guard(mutex)() macro Joshua Crofts via B4 Relay
2026-04-28 15:20 ` Jonathan Cameron
2026-04-28 16:27 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428-si1133-checkup-v2-2-70ad14bfefe2@gmail.com \
--to=devnull+joshua.crofts1.gmail.com@kernel.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox