From: Jonathan Cameron <jic23@kernel.org>
To: Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org>
Cc: joshua.crofts1@gmail.com, "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/5] iio: light: si1133: group generic <linux/*> headers
Date: Tue, 28 Apr 2026 16:14:17 +0100 [thread overview]
Message-ID: <20260428161417.20b73314@jic23-huawei> (raw)
In-Reply-To: <20260428-si1133-checkup-v2-4-70ad14bfefe2@gmail.com>
On Tue, 28 Apr 2026 15:18:36 +0200
Joshua Crofts via B4 Relay <devnull+joshua.crofts1.gmail.com@kernel.org> wrote:
> From: Joshua Crofts <joshua.crofts1@gmail.com>
>
> Group generic <linux/*> include headers to improve code style.
Not particularly important but you could mention why these two are
where they are. For the unaligned one that was a mass replacement
of asm/unaligned with linux/unaligned that didn't reflect local
ordering. No idea for util_macros.h!
>
> No functional change.
>
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
> ---
> drivers/iio/light/si1133.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/iio/light/si1133.c b/drivers/iio/light/si1133.c
> index 5c5c5ae0535a9592522c0b21496f47068044c6ff..f2a79675c026c86bb56d85a65cd035d7540d0ef8 100644
> --- a/drivers/iio/light/si1133.c
> +++ b/drivers/iio/light/si1133.c
> @@ -21,14 +21,12 @@
> #include <linux/mutex.h>
> #include <linux/regmap.h>
> #include <linux/types.h>
> +#include <linux/unaligned.h>
> +#include <linux/util_macros.h>
>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
>
> -#include <linux/util_macros.h>
> -
> -#include <linux/unaligned.h>
> -
> #define SI1133_REG_PART_ID 0x00
> #define SI1133_REG_REV_ID 0x01
> #define SI1133_REG_MFR_ID 0x02
>
next prev parent reply other threads:[~2026-04-28 15:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 13:18 [PATCH v2 0/5] iio: light: si1133: driver cleanup Joshua Crofts via B4 Relay
2026-04-28 13:18 ` [PATCH v2 1/5] iio: light: si1133: prefer complex macros enclosed in parenthesis Joshua Crofts via B4 Relay
2026-04-28 13:18 ` [PATCH v2 2/5] iio: light: si1133: remove unused macros Joshua Crofts via B4 Relay
2026-04-28 15:12 ` Jonathan Cameron
2026-04-28 16:25 ` Joshua Crofts
2026-04-28 13:18 ` [PATCH v2 3/5] iio: light: si1133: add missing include headers Joshua Crofts via B4 Relay
2026-04-28 13:18 ` [PATCH v2 4/5] iio: light: si1133: group generic <linux/*> headers Joshua Crofts via B4 Relay
2026-04-28 15:14 ` Jonathan Cameron [this message]
2026-04-28 13:18 ` [PATCH v2 5/5] iio: light: si1133: use guard(mutex)() macro Joshua Crofts via B4 Relay
2026-04-28 15:20 ` Jonathan Cameron
2026-04-28 16:27 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428161417.20b73314@jic23-huawei \
--to=jic23@kernel.org \
--cc=andy@kernel.org \
--cc=devnull+joshua.crofts1.gmail.com@kernel.org \
--cc=dlechner@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox