From: Jonathan Cameron <jic23@kernel.org>
To: Maxwell Doose <m32285159@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
songqiang1304521@gmail.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] iio: magnetometer: rm3100: Use guard(mutex)() in rm3100_read_mag()
Date: Tue, 28 Apr 2026 16:58:53 +0100 [thread overview]
Message-ID: <20260428165853.0f7a7b58@jic23-huawei> (raw)
In-Reply-To: <CAKqfh0G+PXj8sDaJATKJmywghesm+NOJoEff1bC_gsncHQxwnw@mail.gmail.com>
On Tue, 28 Apr 2026 09:59:55 -0500
Maxwell Doose <m32285159@gmail.com> wrote:
> On Tue, Apr 28, 2026 at 8:26 AM Andy Shevchenko
> <andriy.shevchenko@intel.com> wrote:
> >
> > Perhaps we need to also put a summary of the extended critical section, so that
> > it will be clear that we thought about it and decided to cover that small memory
> > access + some bitops.
> >
> > Otherwise LGTM.
> >
>
> Sounds good, but I'm going to wait 1 or 2 days to see if a maintainer
> wants to comment on whether or not we *need* the summary about the
> mutex scope. If they don't say anything I'll probably just send a v3
> with the summary added in the commit message.
Where scope changes, it is indeed good to add a brief note on what
ends up incorporated in the expanded scope and whether that is worth
thinking about or not when reviewing the patch.
Here I think it's easy to conclude we don't care. The last patch not
so much!
J
>
> best regards,
> maxwell
next prev parent reply other threads:[~2026-04-28 15:59 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-28 12:46 [PATCH 0/4] iio: magnetometer: rm3100: Modernize locking and control flow Maxwell Doose
2026-04-28 12:46 ` [PATCH v2 1/4] iio: magnetometer: rm3100: Use guard(mutex)() in rm3100_read_mag() Maxwell Doose
2026-04-28 13:26 ` Andy Shevchenko
2026-04-28 14:59 ` Maxwell Doose
2026-04-28 15:58 ` Jonathan Cameron [this message]
2026-04-28 12:46 ` [PATCH v2 2/4] iio: magnetometer: rm3100: Use scoped_guard() in rm3100_get_samp_freq() Maxwell Doose
2026-04-28 13:26 ` Andy Shevchenko
2026-04-28 13:59 ` Maxwell Doose
2026-04-28 15:24 ` Jonathan Cameron
2026-04-28 17:08 ` Maxwell Doose
2026-04-28 12:46 ` [PATCH v2 3/4] iio: magnetometer: rm3100: Use guard(mutex)() in rm3100_set_samp_freq() Maxwell Doose
2026-04-28 12:46 ` [PATCH v2 4/4] iio: magnetometer: rm3100: Use guard(mutex)() in rm3100_trigger_handler() Maxwell Doose
2026-04-28 15:32 ` Jonathan Cameron
2026-04-28 17:20 ` Maxwell Doose
2026-04-28 17:27 ` Maxwell Doose
2026-04-28 17:39 ` Jonathan Cameron
2026-04-28 19:09 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428165853.0f7a7b58@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
--cc=songqiang1304521@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox