From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Natália Salvino André" <natalia.andre@ime.usp.br>,
andy@kernel.org, bentiss@kernel.org, dlechner@baylibre.com,
jikos@kernel.org, nuno.sa@analog.com,
srinivas.pandruvada@linux.intel.com,
"Pietro Di Consolo Gregorio" <pietro.gregorio@usp.br>,
linux-iio@vger.kernel.org, linux-input@vger.kernel.org
Subject: Re: [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask()
Date: Tue, 28 Apr 2026 19:12:46 +0100 [thread overview]
Message-ID: <20260428191246.152c2972@jic23-huawei> (raw)
In-Reply-To: <ae8upGN9ILmtCzeA@ashevche-desk.local>
On Mon, 27 Apr 2026 12:38:44 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Fri, Apr 24, 2026 at 08:08:47PM +0100, Jonathan Cameron wrote:
> > On Wed, 22 Apr 2026 12:07:07 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > > On Tue, Apr 21, 2026 at 07:20:34PM -0300, Natália Salvino André wrote:
>
> ...
>
> > > > - accel_3d_adjust_channel_bit_mask(channels,
> > > > - CHANNEL_SCAN_INDEX_X + i,
> > > > - st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > > > + hid_sensor_adjust_channel_bit_mask(channels,
> > > > + CHANNEL_SCAN_INDEX_X + i,
> > > > + st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > >
> > > Indentation is broken. Taking into account that the last line is too long when
> > > properly indented, perhaps
> > >
> > > hid_sensor_adjust_channel_bit_mask(channels,
> > > CHANNEL_SCAN_INDEX_X + i,
> > > st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > >
> > > Which makes it most right and under 80 limit.
>
> > Why the double tab? Maybe just go long on this one and align after the (
>
> I never know when you are strict about 80 limit :-)
>
I was meaning vs single tab really.
You are slowly wearing me down on the 80 limit by pointing out lots of
cases where going beyond it really helps! ;)
next prev parent reply other threads:[~2026-04-28 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260421222210.16016-1-natalia.andre@ime.usp.br>
[not found] ` <20260421222210.16016-3-natalia.andre@ime.usp.br>
[not found] ` <aeiPuxj2TRLNRbv1@ashevche-desk.local>
[not found] ` <20260424200847.78494f27@jic23-huawei>
2026-04-27 9:38 ` [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask() Andy Shevchenko
2026-04-28 18:12 ` Jonathan Cameron [this message]
2026-04-29 19:54 ` Andy Shevchenko
[not found] ` <20260421222210.16016-2-natalia.andre@ime.usp.br>
[not found] ` <aeiO0JRGW0oKdcON@ashevche-desk.local>
[not found] ` <20260424200155.61b6f273@jic23-huawei>
2026-04-27 9:39 ` [PATCH v2 1/7] iio: HID: Add helper method hid_sensor_adjust_channel_bit_mask() Andy Shevchenko
[not found] ` <20260424202337.530d5aad@jic23-huawei>
2026-04-27 18:26 ` srinivas pandruvada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428191246.152c2972@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=bentiss@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=natalia.andre@ime.usp.br \
--cc=nuno.sa@analog.com \
--cc=pietro.gregorio@usp.br \
--cc=srinivas.pandruvada@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox