Re: [PATCH v2 2/7] iio: accel: HID: Replace method accel_3d_adjust_channel_bit_mask()

[Andy Shevchenko <andriy.shevchenko@intel.com>]

On Tue, Apr 28, 2026 at 07:12:46PM +0100, Jonathan Cameron wrote:
> On Mon, 27 Apr 2026 12:38:44 +0300
> Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> > On Fri, Apr 24, 2026 at 08:08:47PM +0100, Jonathan Cameron wrote:
> > > On Wed, 22 Apr 2026 12:07:07 +0300
> > > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:  
> > > > On Tue, Apr 21, 2026 at 07:20:34PM -0300, Natália Salvino André wrote:  

...

> > > > > -		accel_3d_adjust_channel_bit_mask(channels,
> > > > > -				CHANNEL_SCAN_INDEX_X + i,
> > > > > -				st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > > > > +		hid_sensor_adjust_channel_bit_mask(channels,
> > > > > +			CHANNEL_SCAN_INDEX_X + i,
> > > > > +			st->accel[CHANNEL_SCAN_INDEX_X + i].size);    
> > > > 
> > > > Indentation is broken. Taking into account that the last line is too long when
> > > > properly indented, perhaps
> > > > 
> > > > 		hid_sensor_adjust_channel_bit_mask(channels,
> > > > 				CHANNEL_SCAN_INDEX_X + i,
> > > > 				st->accel[CHANNEL_SCAN_INDEX_X + i].size);
> > > > 
> > > > Which makes it most right and under 80 limit.  
> > 
> > > Why the double tab? Maybe just go long on this one and align after the (  
> > 
> > I never know when you are strict about 80 limit :-)
> > 
> I was meaning vs single tab really.

Ah, my point if the line is too long and maintainer is too strict about
the limit the indentation I would like to use is to occupy as much room as
possible. I.o.w. to indent right as much as possible to fit the limit.

> You are slowly wearing me down on the 80 limit by pointing out lots of
> cases where going beyond it really helps! ;)

Ha-ha :-)

-- 
With Best Regards,
Andy Shevchenko