From: Jonathan Cameron <jic23@kernel.org>
To: Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com>
Cc: Andy Shevchenko <andriy.shevchenko@intel.com>,
antoniu.miclaus@analog.com, lars@metafoo.de,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h>
Date: Tue, 28 Apr 2026 19:14:23 +0100 [thread overview]
Message-ID: <20260428191423.28888451@jic23-huawei> (raw)
In-Reply-To: <CAE7dp2pUnDbEHPGvxVE5VkaYeV2rEWnTNfdqGaSy1DjZxge-Dw@mail.gmail.com>
On Mon, 27 Apr 2026 15:29:57 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:
> On Fri, Apr 24, 2026 at 8:58 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
>
> > > Why do we need to have kmalloc() here at all? I don't understand that.
> > Absolutely. Locally it looks like length might be large and therefore
> > the array not suitable to be on the stack, but that's not the case.
> > length == 2 so the array only has 4 elements and can go on the stack.
> >
> > >
> > > > This function is just overly flexible.
> > >
> >
>
> Thanks Jonathan and Andy. I have sent v2.
Whilst you are welcome you've fallen into the process related trap
of being too polite! Better to thank us in the change log of v2
and we all have one less email to check.
Note, pretty much everyone does this when they start working on the
kernel and so get this email once!
Jonathan
prev parent reply other threads:[~2026-04-28 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260424081809.61841-2-giorgitchankvetadze1997@gmail.com>
[not found] ` <aesyzOMUl2Iyjgjz@ashevche-desk.local>
[not found] ` <20260424113600.4e76fdb7@jic23-huawei>
[not found] ` <aetVGYQcq1NAJb7k@ashevche-desk.local>
[not found] ` <20260424175753.2d0ca494@jic23-huawei>
2026-04-27 11:29 ` [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h> Giorgi Tchankvetadze
2026-04-28 18:14 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260428191423.28888451@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=antoniu.miclaus@analog.com \
--cc=dlechner@baylibre.com \
--cc=giorgitchankvetadze1997@gmail.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox