* Re: [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h>
[not found] ` <20260424175753.2d0ca494@jic23-huawei>
@ 2026-04-27 11:29 ` Giorgi Tchankvetadze
2026-04-28 18:14 ` Jonathan Cameron
0 siblings, 1 reply; 2+ messages in thread
From: Giorgi Tchankvetadze @ 2026-04-27 11:29 UTC (permalink / raw)
To: Jonathan Cameron
Cc: Andy Shevchenko, antoniu.miclaus, lars, Michael.Hennerich,
dlechner, nuno.sa, andy, linux-iio, linux-kernel
On Fri, Apr 24, 2026 at 8:58 PM Jonathan Cameron <jic23@kernel.org> wrote:
>
> > Why do we need to have kmalloc() here at all? I don't understand that.
> Absolutely. Locally it looks like length might be large and therefore
> the array not suitable to be on the stack, but that's not the case.
> length == 2 so the array only has 4 elements and can go on the stack.
>
> >
> > > This function is just overly flexible.
> >
>
Thanks Jonathan and Andy. I have sent v2.
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h>
2026-04-27 11:29 ` [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h> Giorgi Tchankvetadze
@ 2026-04-28 18:14 ` Jonathan Cameron
0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2026-04-28 18:14 UTC (permalink / raw)
To: Giorgi Tchankvetadze
Cc: Andy Shevchenko, antoniu.miclaus, lars, Michael.Hennerich,
dlechner, nuno.sa, andy, linux-iio, linux-kernel
On Mon, 27 Apr 2026 15:29:57 +0400
Giorgi Tchankvetadze <giorgitchankvetadze1997@gmail.com> wrote:
> On Fri, Apr 24, 2026 at 8:58 PM Jonathan Cameron <jic23@kernel.org> wrote:
> >
>
> > > Why do we need to have kmalloc() here at all? I don't understand that.
> > Absolutely. Locally it looks like length might be large and therefore
> > the array not suitable to be on the stack, but that's not the case.
> > length == 2 so the array only has 4 elements and can go on the stack.
> >
> > >
> > > > This function is just overly flexible.
> > >
> >
>
> Thanks Jonathan and Andy. I have sent v2.
Whilst you are welcome you've fallen into the process related trap
of being too polite! Better to thank us in the change log of v2
and we all have one less email to check.
Note, pretty much everyone does this when they start working on the
kernel and so get this email once!
Jonathan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-04-28 18:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20260424081809.61841-2-giorgitchankvetadze1997@gmail.com>
[not found] ` <aesyzOMUl2Iyjgjz@ashevche-desk.local>
[not found] ` <20260424113600.4e76fdb7@jic23-huawei>
[not found] ` <aetVGYQcq1NAJb7k@ashevche-desk.local>
[not found] ` <20260424175753.2d0ca494@jic23-huawei>
2026-04-27 11:29 ` [PATCH] iio: adc: ti-ads7138: explicitly include <linux/slab.h> Giorgi Tchankvetadze
2026-04-28 18:14 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox