* Re: [PATCH v2] iio: adxl313: fix typos in documentation
@ 2026-05-02 12:53 Wang Zihan
2026-05-04 16:38 ` Jonathan Cameron
0 siblings, 1 reply; 6+ messages in thread
From: Wang Zihan @ 2026-05-02 12:53 UTC (permalink / raw)
To: joshua.crofts1; +Cc: jic23, linux-iio, linux-doc, Wang Zihan
Hi Joshua,
Thank you for the review!
I apologize for the quick v2. The v1 had an incorrect subject format
([PATCH 1/4] instead of [PATCH]) which could cause confusion. I sent
v2 to correct this formatting issue.
I will keep the 24-hour rule in mind for future submissions.
Best regards,
Wang Zihan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: adxl313: fix typos in documentation
2026-05-02 12:53 [PATCH v2] iio: adxl313: fix typos in documentation Wang Zihan
@ 2026-05-04 16:38 ` Jonathan Cameron
0 siblings, 0 replies; 6+ messages in thread
From: Jonathan Cameron @ 2026-05-04 16:38 UTC (permalink / raw)
To: Wang Zihan; +Cc: joshua.crofts1, linux-iio, linux-doc
On Sat, 2 May 2026 20:53:43 +0800
Wang Zihan <jiyu03@qq.com> wrote:
> Hi Joshua,
>
> Thank you for the review!
>
> I apologize for the quick v2. The v1 had an incorrect subject format
> ([PATCH 1/4] instead of [PATCH]) which could cause confusion. I sent
> v2 to correct this formatting issue.
Make sure you include a change log below the ---
That would have let Joshua and the rest of us know why you resent.
Particularly important when doing a quick resend.
Thanks,
Jonathan
>
> I will keep the 24-hour rule in mind for future submissions.
>
> Best regards,
> Wang Zihan
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] iio: adxl313: fix typos in documentation
@ 2026-05-02 6:07 Wang Zihan
2026-05-02 12:45 ` Joshua Crofts
2026-05-04 16:43 ` Jonathan Cameron
0 siblings, 2 replies; 6+ messages in thread
From: Wang Zihan @ 2026-05-02 6:07 UTC (permalink / raw)
To: jic23; +Cc: linux-iio, linux-doc, Wang Zihan
Add missing space in "ADXL313is" and correct "a single types"
to "a single type".
Signed-off-by: Wang Zihan <jiyu03@qq.com>
---
Documentation/iio/adxl313.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/iio/adxl313.rst b/Documentation/iio/adxl313.rst
index 966e72c01..3662153a6 100644
--- a/Documentation/iio/adxl313.rst
+++ b/Documentation/iio/adxl313.rst
@@ -11,7 +11,7 @@ This driver supports Analog Device's ADXL313 on SPI/I2C bus.
* `ADXL313 <https://www.analog.com/ADXL313>`_
-The ADXL313is a low noise density, low power, 3-axis accelerometer with
+The ADXL313 is a low noise density, low power, 3-axis accelerometer with
selectable measurement ranges. The ADXL313 supports the ±0.5 g, ±1 g, ±2 g and
±4 g ranges.
@@ -112,7 +112,7 @@ apply the following formula:
Where _offset and _scale are device attributes. If no _offset attribute is
present, simply assume its value is 0.
-The ADXL313 driver offers data for a single types of channels, the table below
+The ADXL313 driver offers data for a single type of channels, the table below
shows the measurement units for the processed value, which are defined by the
IIO framework:
--
2.54.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: adxl313: fix typos in documentation
2026-05-02 6:07 Wang Zihan
@ 2026-05-02 12:45 ` Joshua Crofts
2026-05-04 16:43 ` Jonathan Cameron
1 sibling, 0 replies; 6+ messages in thread
From: Joshua Crofts @ 2026-05-02 12:45 UTC (permalink / raw)
To: Wang Zihan; +Cc: jic23, linux-iio, linux-doc
On Sat, 2 May 2026 at 08:07, Wang Zihan <jiyu03@qq.com> wrote:
>
> Add missing space in "ADXL313is" and correct "a single types"
> to "a single type".
>
> Signed-off-by: Wang Zihan <jiyu03@qq.com>
> ---
> Documentation/iio/adxl313.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/iio/adxl313.rst b/Documentation/iio/adxl313.rst
> index 966e72c01..3662153a6 100644
> --- a/Documentation/iio/adxl313.rst
> +++ b/Documentation/iio/adxl313.rst
> @@ -11,7 +11,7 @@ This driver supports Analog Device's ADXL313 on SPI/I2C bus.
>
> * `ADXL313 <https://www.analog.com/ADXL313>`_
>
> -The ADXL313is a low noise density, low power, 3-axis accelerometer with
> +The ADXL313 is a low noise density, low power, 3-axis accelerometer with
> selectable measurement ranges. The ADXL313 supports the ±0.5 g, ±1 g, ±2 g and
> ±4 g ranges.
>
> @@ -112,7 +112,7 @@ apply the following formula:
> Where _offset and _scale are device attributes. If no _offset attribute is
> present, simply assume its value is 0.
>
> -The ADXL313 driver offers data for a single types of channels, the table below
> +The ADXL313 driver offers data for a single type of channels, the table below
> shows the measurement units for the processed value, which are defined by the
> IIO framework:
>
> --
> 2.54.0
>
>
FYI, please wait 24 hours before sending a v2.
Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
--
Kind regards
CJD
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: adxl313: fix typos in documentation
2026-05-02 6:07 Wang Zihan
2026-05-02 12:45 ` Joshua Crofts
@ 2026-05-04 16:43 ` Jonathan Cameron
2026-05-04 17:21 ` Joshua Crofts
1 sibling, 1 reply; 6+ messages in thread
From: Jonathan Cameron @ 2026-05-04 16:43 UTC (permalink / raw)
To: Wang Zihan; +Cc: linux-iio, linux-doc
On Sat, 2 May 2026 14:07:00 +0800
Wang Zihan <jiyu03@qq.com> wrote:
> Add missing space in "ADXL313is" and correct "a single types"
> to "a single type".
>
> Signed-off-by: Wang Zihan <jiyu03@qq.com>
> ---
> Documentation/iio/adxl313.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/iio/adxl313.rst b/Documentation/iio/adxl313.rst
> index 966e72c01..3662153a6 100644
> --- a/Documentation/iio/adxl313.rst
> +++ b/Documentation/iio/adxl313.rst
> @@ -11,7 +11,7 @@ This driver supports Analog Device's ADXL313 on SPI/I2C bus.
>
> * `ADXL313 <https://www.analog.com/ADXL313>`_
>
> -The ADXL313is a low noise density, low power, 3-axis accelerometer with
> +The ADXL313 is a low noise density, low power, 3-axis accelerometer with
> selectable measurement ranges. The ADXL313 supports the ±0.5 g, ±1 g, ±2 g and
> ±4 g ranges.
>
> @@ -112,7 +112,7 @@ apply the following formula:
> Where _offset and _scale are device attributes. If no _offset attribute is
> present, simply assume its value is 0.
>
> -The ADXL313 driver offers data for a single types of channels, the table below
> +The ADXL313 driver offers data for a single type of channels, the table below
ooh. That's fun grammar. Intent is that there are multiple channels of one type
but the form used in your corrected version is at best unwieldy given plural
singular mix. "a single type of channel" is fine for instance but this isn't really.
I'd rewrite as
The ADXL313 driver offers data for multiple channels of a single type. The table
below...
(so split he thing up into two sentences as well).
> shows the measurement units for the processed value, which are defined by the
> IIO framework:
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] iio: adxl313: fix typos in documentation
2026-05-04 16:43 ` Jonathan Cameron
@ 2026-05-04 17:21 ` Joshua Crofts
0 siblings, 0 replies; 6+ messages in thread
From: Joshua Crofts @ 2026-05-04 17:21 UTC (permalink / raw)
To: Jonathan Cameron; +Cc: Wang Zihan, linux-iio, linux-doc
On Mon, 4 May 2026 at 18:43, Jonathan Cameron <jic23@kernel.org> wrote:
>
> On Sat, 2 May 2026 14:07:00 +0800
> Wang Zihan <jiyu03@qq.com> wrote:
>
> > Add missing space in "ADXL313is" and correct "a single types"
> > to "a single type".
> >
> > Signed-off-by: Wang Zihan <jiyu03@qq.com>
> > ---
> > Documentation/iio/adxl313.rst | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/iio/adxl313.rst b/Documentation/iio/adxl313.rst
> > index 966e72c01..3662153a6 100644
> > --- a/Documentation/iio/adxl313.rst
> > +++ b/Documentation/iio/adxl313.rst
> > @@ -11,7 +11,7 @@ This driver supports Analog Device's ADXL313 on SPI/I2C bus.
> >
> > * `ADXL313 <https://www.analog.com/ADXL313>`_
> >
> > -The ADXL313is a low noise density, low power, 3-axis accelerometer with
> > +The ADXL313 is a low noise density, low power, 3-axis accelerometer with
> > selectable measurement ranges. The ADXL313 supports the ±0.5 g, ±1 g, ±2 g and
> > ±4 g ranges.
> >
> > @@ -112,7 +112,7 @@ apply the following formula:
> > Where _offset and _scale are device attributes. If no _offset attribute is
> > present, simply assume its value is 0.
> >
> > -The ADXL313 driver offers data for a single types of channels, the table below
> > +The ADXL313 driver offers data for a single type of channels, the table below
>
> ooh. That's fun grammar. Intent is that there are multiple channels of one type
> but the form used in your corrected version is at best unwieldy given plural
> singular mix. "a single type of channel" is fine for instance but this isn't really.
Ah, my bad, the space is fine but reading it a second time - it does seem off.
--
Kind regards
CJD
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-05-04 17:21 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-02 12:53 [PATCH v2] iio: adxl313: fix typos in documentation Wang Zihan
2026-05-04 16:38 ` Jonathan Cameron
-- strict thread matches above, loose matches on Subject: below --
2026-05-02 6:07 Wang Zihan
2026-05-02 12:45 ` Joshua Crofts
2026-05-04 16:43 ` Jonathan Cameron
2026-05-04 17:21 ` Joshua Crofts
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox