From: Kim Seer Paller <kimseer.paller@analog.com>
To: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>
Cc: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Kim Seer Paller <kimseer.paller@analog.com>,
Jonathan Cameron <jic23@kernel.org>
Subject: [PATCH 0/2] Fix AD3531/AD3531R powerdown modes
Date: Tue, 5 May 2026 12:34:30 +0800 [thread overview]
Message-ID: <20260505-dev-ad3531r-v1-0-2b4cc55f69e7@analog.com> (raw)
The AD3531/AD3531R has different powerdown output impedance modes from
the AD3530/AD3530R. The driver currently uses the AD3530R modes (1k,
7.7k, 32k) for all variants, which is incorrect for the AD3531/AD3531R
which has 500 Ohm, 3.85 kOhm, and 16 kOhm modes per the datasheet.
This series adds the missing ABI entries for the new powerdown modes
and fixes the driver to use the correct mode strings for AD3531/AD3531R
chip variants.
Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
---
Kim Seer Paller (2):
iio: ABI: Add DAC 500ohm, 3.85kohm, and 16kohm powerdown modes
iio: dac: ad3530r: Fix AD3531/AD3531R powerdown mode strings
Documentation/ABI/testing/sysfs-bus-iio | 3 ++
drivers/iio/dac/ad3530r.c | 54 ++++++++++++++++++++++++---------
2 files changed, 43 insertions(+), 14 deletions(-)
---
base-commit: 39b80c5c9830d12d2d6531059001301c4265322a
change-id: 20260505-dev-ad3531r-2a3091fc7c12
Best regards,
--
Kim Seer Paller <kimseer.paller@analog.com>
next reply other threads:[~2026-05-05 4:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 4:34 Kim Seer Paller [this message]
2026-05-05 4:34 ` [PATCH 1/2] iio: ABI: Add DAC 500ohm, 3.85kohm, and 16kohm powerdown modes Kim Seer Paller
2026-05-06 16:23 ` Jonathan Cameron
2026-05-05 4:34 ` [PATCH 2/2] iio: dac: ad3530r: Fix AD3531/AD3531R powerdown mode strings Kim Seer Paller
2026-05-06 16:25 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505-dev-ad3531r-v1-0-2b4cc55f69e7@analog.com \
--to=kimseer.paller@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox