From: Jonathan Cameron <jic23@kernel.org>
To: Kim Seer Paller <kimseer.paller@analog.com>
Cc: "David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"Michael Hennerich" <Michael.Hennerich@analog.com>,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] iio: dac: ad3530r: Fix AD3531/AD3531R powerdown mode strings
Date: Wed, 6 May 2026 17:25:23 +0100 [thread overview]
Message-ID: <20260506172523.77e095c6@jic23-huawei> (raw)
In-Reply-To: <20260505-dev-ad3531r-v1-2-2b4cc55f69e7@analog.com>
On Tue, 5 May 2026 12:34:32 +0800
Kim Seer Paller <kimseer.paller@analog.com> wrote:
> The AD3531/AD3531R has different output operating modes from the
> AD3530/AD3530R. According to the AD3531/AD3531R datasheet, the
> powerdown modes are:
> 01: 500 Ohm output impedance
> 10: 3.85 kOhm output impedance
> 11: 16 kOhm output impedance
>
> The driver currently uses the AD3530R modes (1k, 7.7k, 32k) for all
> variants, which is incorrect for AD3531/AD3531R.
>
> Add AD3531R-specific powerdown mode strings and assign them to the
> AD3531/AD3531R chip variants.
>
> Fixes: 93583174a3df ("iio: dac: ad3530r: Add driver for AD3530R and AD3531R")
> Signed-off-by: Kim Seer Paller <kimseer.paller@analog.com>
Applied to the fixes-togreg branch of iio.git and marked for stable
Thanks,
Jonathan
prev parent reply other threads:[~2026-05-06 16:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 4:34 [PATCH 0/2] Fix AD3531/AD3531R powerdown modes Kim Seer Paller
2026-05-05 4:34 ` [PATCH 1/2] iio: ABI: Add DAC 500ohm, 3.85kohm, and 16kohm " Kim Seer Paller
2026-05-06 16:23 ` Jonathan Cameron
2026-05-05 4:34 ` [PATCH 2/2] iio: dac: ad3530r: Fix AD3531/AD3531R powerdown mode strings Kim Seer Paller
2026-05-06 16:25 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260506172523.77e095c6@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=kimseer.paller@analog.com \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox