From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: "Guilherme Dias" <guilhermeabreu200105@usp.br>,
nish.malpani25@gmail.com, lars@metafoo.de,
Michael.Hennerich@analog.com, dlechner@baylibre.com,
nuno.sa@analog.com, andy@kernel.org,
"João Paulo Menezes Linaris" <jplinaris@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5] iio: gyro: adxrs290: Use guard(mutex) in lieu of manual lock+unlock
Date: Tue, 5 May 2026 13:21:36 +0100 [thread overview]
Message-ID: <20260505132136.46cb7925@jic23-huawei> (raw)
In-Reply-To: <afmvD1EB159V498L@ashevche-desk.local>
On Tue, 5 May 2026 11:49:19 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Mon, May 04, 2026 at 04:04:25PM -0300, Guilherme Dias wrote:
> > Use guard(mutex) to automatically release the lock on scope exit,
>
> Better to point that guard is kinda "operator" and hence we refer to it as
> guard()() [note double parentheses], but it's minor, just for the future.
>
> > simplifying the error handling path and removing the need for
> > explicit unlock and goto-based cleanup.
>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Applied to the testing branch of iio.git
Thanks for the patch and thanks to all those involved in review!
Jonathan
prev parent reply other threads:[~2026-05-05 12:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 19:04 [PATCH v5] iio: gyro: adxrs290: Use guard(mutex) in lieu of manual lock+unlock Guilherme Dias
2026-05-05 0:29 ` Maxwell Doose
2026-05-05 8:49 ` Andy Shevchenko
2026-05-05 12:21 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505132136.46cb7925@jic23-huawei \
--to=jic23@kernel.org \
--cc=Michael.Hennerich@analog.com \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=guilhermeabreu200105@usp.br \
--cc=jplinaris@usp.br \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox