From: "Maxwell Doose" <m32285159@gmail.com>
To: "Guilherme Dias" <guilhermeabreu200105@usp.br>,
<nish.malpani25@gmail.com>, <lars@metafoo.de>,
<Michael.Hennerich@analog.com>, <jic23@kernel.org>,
<dlechner@baylibre.com>, <nuno.sa@analog.com>, <andy@kernel.org>
Cc: "João Paulo Menezes Linaris" <jplinaris@usp.br>,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5] iio: gyro: adxrs290: Use guard(mutex) in lieu of manual lock+unlock
Date: Mon, 04 May 2026 19:29:34 -0500 [thread overview]
Message-ID: <DIABH47DS3A6.J29LEHJY7CIW@gmail.com> (raw)
In-Reply-To: <20260504190455.9841-1-guilhermeabreu200105@usp.br>
On Mon May 4, 2026 at 2:04 PM CDT, Guilherme Dias wrote:
> Use guard(mutex) to automatically release the lock on scope exit,
> simplifying the error handling path and removing the need for
> explicit unlock and goto-based cleanup.
>
> Signed-off-by: Guilherme Dias <guilhermeabreu200105@usp.br>
> Co-developed-by: João Paulo Menezes Linaris <jplinaris@usp.br>
> Signed-off-by: João Paulo Menezes Linaris <jplinaris@usp.br>
> ---
> v5:
> - add cleanup.h
>
> v4:
> - fix indentation
>
> drivers/iio/gyro/adxrs290.c | 75 +++++++++++++++----------------------
> 1 file changed, 31 insertions(+), 44 deletions(-)
>
LGTM.
Reviewed-by: Maxwell Doose <m32285159@gmail.com>
best regards,
max
next prev parent reply other threads:[~2026-05-05 0:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 19:04 [PATCH v5] iio: gyro: adxrs290: Use guard(mutex) in lieu of manual lock+unlock Guilherme Dias
2026-05-05 0:29 ` Maxwell Doose [this message]
2026-05-05 8:49 ` Andy Shevchenko
2026-05-05 12:21 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DIABH47DS3A6.J29LEHJY7CIW@gmail.com \
--to=m32285159@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=guilhermeabreu200105@usp.br \
--cc=jic23@kernel.org \
--cc=jplinaris@usp.br \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=nish.malpani25@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox