From: Jonathan Cameron <jic23@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@intel.com>
Cc: Marcelo Machado Lage <marcelomlage@usp.br>,
andy@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v4 0/2] iio: adc: mcp3422: apply bit manipulation macros
Date: Tue, 5 May 2026 17:22:14 +0100 [thread overview]
Message-ID: <20260505172214.6f0025d3@jic23-huawei> (raw)
In-Reply-To: <afLyk-kNyZkr_drR@ashevche-desk.local>
On Thu, 30 Apr 2026 09:11:31 +0300
Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> On Wed, Apr 29, 2026 at 07:43:59PM -0300, Marcelo Machado Lage wrote:
> > This patch set rewrites several open-coded bit manipulation parts of
> > the MCP3421/2/3/4/5/6/7/8 driver code using bits.h and bitfield.h
> > macros.
>
> Both LGTM now
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
>
Nice. Applied to the testing branch of iio.git.
FWIW Sashiko had a field day on 'whilst I was here' things in this driver:
https://sashiko.dev/#/patchset/20260429224401.11818-1-marcelomlage%40usp.br
Note that the DMA one is wrong. Some of the others might or might not be correct.
Maybe some stuff to look at if you want to do more work on this driver, though
you'll probably need to work out some way of testing fixes for the more complex
ones.
Thanks,
Jonathan
next prev parent reply other threads:[~2026-05-05 16:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 22:43 [PATCH v4 0/2] iio: adc: mcp3422: apply bit manipulation macros Marcelo Machado Lage
2026-04-29 22:44 ` [PATCH v4 1/2] iio: adc: mcp3422: rewrite mask macros with help of bits.h APIs Marcelo Machado Lage
2026-04-29 22:44 ` [PATCH v4 2/2] iio: adc: mcp3422: write bit operations using bitfield.h APIs Marcelo Machado Lage
2026-04-30 6:11 ` [PATCH v4 0/2] iio: adc: mcp3422: apply bit manipulation macros Andy Shevchenko
2026-05-05 16:22 ` Jonathan Cameron [this message]
2026-05-09 14:09 ` Marcelo Machado Lage
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260505172214.6f0025d3@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=linux-iio@vger.kernel.org \
--cc=marcelomlage@usp.br \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox