Re: [PATCH v4 0/2] iio: adc: mcp3422: apply bit manipulation macros

[Jonathan Cameron <jic23@kernel.org>]

On Sat, 9 May 2026 11:09:06 -0300
Marcelo Machado Lage <marcelomlage@usp.br> wrote:

> On Tue, 5 May 2026 at 13:22, Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Thu, 30 Apr 2026 09:11:31 +0300
> > Andy Shevchenko <andriy.shevchenko@intel.com> wrote:
> >  
> > > On Wed, Apr 29, 2026 at 07:43:59PM -0300, Marcelo Machado Lage wrote:  
> > > > This patch set rewrites several open-coded bit manipulation parts of
> > > > the MCP3421/2/3/4/5/6/7/8 driver code using bits.h and bitfield.h
> > > > macros.  
> > >
> > > Both LGTM now
> > > Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
> > >  
> > Nice.  Applied to the testing branch of iio.git.  
> 
> Thanks for the reviews! We're happy to see our patch applied!
> 
> > FWIW Sashiko had a field day on 'whilst I was here' things in this driver:
> > https://sashiko.dev/#/patchset/20260429224401.11818-1-marcelomlage%40usp.br
> >
> > Note that the DMA one is wrong. Some of the others might or might not be correct.
> > Maybe some stuff to look at if you want to do more work on this driver, though
> > you'll probably need to work out some way of testing fixes for the more complex
> > ones.  
> 
> Thanks for pointing out Sashiko's thoughts on this patch.
> Unfortunately, we do not have access to the device for testing complex fixes,
> but we'll definitely study its suggestions for next contributions.
> 
There are other paths to testing that are mostly sufficient.
Best is full functional emulation in something like QEMU but you can also do a
lot with careful stubbing out of functions and prints of device state / what
goes over the bus.  Key to any of these techniques is to state how you tested
in in the cover letter as these methods don't test everything (nor does real
hardware for that matter - given race conditions and rare failure paths)
and reviewers should be aware of what to look out for which depends a bit
on how things were tested.

No problem if you decide it's too time consuming or tricky though!

Jonathan
 
> Best regards,
> Marcelo