From: Maxwell Doose <m32285159@gmail.com>
To: jic23@kernel.org
Cc: "Tomasz Duszynski" <tomasz.duszynski@octakon.com>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error
Date: Sat, 9 May 2026 16:19:20 -0500 [thread overview]
Message-ID: <20260509211921.84969-1-m32285159@gmail.com> (raw)
In scd30_read_raw, the current value of tmp in the
IIO_CHAN_INFO_SAMP_FREQ case is unchecked. Add checking to see if the
value we got was 0 to prevent a divide-by-zero error.
Fixes: 64b3d8b1b0f5 ("iio: chemical: scd30: add core driver")
Signed-off-by: Maxwell Doose <m32285159@gmail.com>
---
drivers/iio/chemical/scd30_core.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
index be8c055be184..3e2bb6f4e42c 100644
--- a/drivers/iio/chemical/scd30_core.c
+++ b/drivers/iio/chemical/scd30_core.c
@@ -237,6 +237,13 @@ static int scd30_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const
if (ret)
return ret;
+ /* Likely only taken if something really strange happens */
+ if (!tmp) {
+ dev_err(&indio_dev->dev,
+ "Invalid measurement interval 0 received\n");
+ return -EIO;
+ }
+
*val = 0;
*val2 = 1000000000 / tmp;
return IIO_VAL_INT_PLUS_NANO;
--
2.54.0
next reply other threads:[~2026-05-09 21:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 21:19 Maxwell Doose [this message]
2026-05-09 21:25 ` [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error David Lechner
2026-05-09 21:36 ` Maxwell Doose
2026-05-09 21:47 ` David Lechner
2026-05-09 21:53 ` Maxwell Doose
2026-05-10 0:47 ` Maxwell Doose
2026-05-11 12:03 ` Jonathan Cameron
2026-05-11 13:31 ` Andy Shevchenko
2026-05-11 14:27 ` Maxwell Doose
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509211921.84969-1-m32285159@gmail.com \
--to=m32285159@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=tomasz.duszynski@octakon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox