Linux IIO development
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Jonathan Cameron <jic23@kernel.org>
Cc: "Maxwell Doose" <m32285159@gmail.com>,
	"David Lechner" <dlechner@baylibre.com>,
	"Tomasz Duszynski" <tomasz.duszynski@octakon.com>,
	"Nuno Sá" <nuno.sa@analog.com>,
	"Andy Shevchenko" <andy@kernel.org>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	"open list" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error
Date: Mon, 11 May 2026 16:31:45 +0300	[thread overview]
Message-ID: <agHaQQs-be2P_fKs@ashevche-desk.local> (raw)
In-Reply-To: <20260511130311.52d65bf6@jic23-huawei>

On Mon, May 11, 2026 at 01:03:10PM +0100, Jonathan Cameron wrote:
> On Sat, 9 May 2026 19:47:53 -0500
> Maxwell Doose <m32285159@gmail.com> wrote:
> > On Sat, May 9, 2026 at 4:53 PM Maxwell Doose <m32285159@gmail.com> wrote:

...

> > Also maybe we update to use dev_err_ratelimited(), sashiko has a good
> > point here:
> > 
> > https://sashiko.dev/#/patchset/20260509211921.84969-1-m32285159%40gmail.com
> > 
> Do we care for something that is going to be a very rare hardware failure?

If it happens rarely, ratelimit is no-op (no change from regular printing),
the only difference if (and I think this is actually what may happen IRL)
there is an intermittent failure of HW and it starts spamming logs like a
hell.

> That's one interesting attack vector. I suppose maybe they have another
> exploit that lets them trip the scd30 into an odd state. 
> 
> Ah well, doesn't do much harm to rate limit it I guess.

-- 
With Best Regards,
Andy Shevchenko



  reply	other threads:[~2026-05-11 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 21:19 [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error Maxwell Doose
2026-05-09 21:25 ` David Lechner
2026-05-09 21:36   ` Maxwell Doose
2026-05-09 21:47     ` David Lechner
2026-05-09 21:53       ` Maxwell Doose
2026-05-10  0:47         ` Maxwell Doose
2026-05-11 12:03           ` Jonathan Cameron
2026-05-11 13:31             ` Andy Shevchenko [this message]
2026-05-11 14:27               ` Maxwell Doose

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agHaQQs-be2P_fKs@ashevche-desk.local \
    --to=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m32285159@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=tomasz.duszynski@octakon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox