From: Md Shofiqul Islam <shofiqtest@gmail.com>
To: jic23@kernel.org
Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org,
dlechner@baylibre.com, mike.looijmans@topic.nl,
nuno.sa@analog.com, andy@kernel.org,
Md Shofiqul Islam <shofiqtest@gmail.com>
Subject: [PATCH v2] iio: adc: ti-ads1298: Fix incorrect timeout comment
Date: Sun, 10 May 2026 11:45:30 +0300 [thread overview]
Message-ID: <20260510084530.3986-1-shofiqtest@gmail.com> (raw)
In-Reply-To: <20260509071910.12345-1-shofiqtest@gmail.com>
At the lowest supported data rate of 250Hz, one conversion period is
4ms, not 40ms. The 50ms timeout is deliberately conservative to allow
for kernel scheduling latency, which can be significant under load or
on slow machines.
Fix the comment to state the correct conversion time, use "lowest sample
rate" for clarity, and explain that the extra margin exists to absorb
scheduling latency so that no one is tempted to shrink the timeout to
match the conversion period.
Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>
---
drivers/iio/adc/ti-ads1298.c | 4 ++--
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c
index cf5f954206..6625d9f0d0 100644
--- a/drivers/iio/adc/ti-ads1298.c
+++ b/drivers/iio/adc/ti-ads1298.c
@@ -210,7 +210,9 @@ static int ads1298_read_one(struct ads1298_private *priv, int chan_index)
return ret;
}
- /* Cannot take longer than 40ms (250Hz) */
+ /* One conversion takes at most 4ms at the lowest sample rate (250Hz).
+ * Use 50ms to allow for kernel scheduling latency.
+ */
ret = wait_for_completion_timeout(&priv->completion, msecs_to_jiffies(50));
if (!ret)
return -ETIMEDOUT;
--
2.54.0.windows.1
next parent reply other threads:[~2026-05-10 8:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260509071910.12345-1-shofiqtest@gmail.com>
2026-05-10 8:45 ` Md Shofiqul Islam [this message]
2026-05-10 10:16 ` [PATCH v2] iio: adc: ti-ads1298: Fix incorrect timeout comment Andy Shevchenko
2026-05-10 12:38 ` [PATCH v3] " Md Shofiqul Islam
2026-05-10 13:01 ` Andy Shevchenko
2026-05-10 19:34 ` [PATCH v4] " Md Shofiqul Islam
2026-05-10 19:36 ` Md Shofiqul Islam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260510084530.3986-1-shofiqtest@gmail.com \
--to=shofiqtest@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox