From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Md Shofiqul Islam <shofiqtest@gmail.com>
Cc: jic23@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, dlechner@baylibre.com,
mike.looijmans@topic.nl, nuno.sa@analog.com, andy@kernel.org
Subject: Re: [PATCH v2] iio: adc: ti-ads1298: Fix incorrect timeout comment
Date: Sun, 10 May 2026 13:16:40 +0300 [thread overview]
Message-ID: <agBbCCWdkh7rJdxb@ashevche-desk.local> (raw)
In-Reply-To: <20260510084530.3986-1-shofiqtest@gmail.com>
On Sun, May 10, 2026 at 11:45:30AM +0300, Md Shofiqul Islam wrote:
> At the lowest supported data rate of 250Hz, one conversion period is
> 4ms, not 40ms. The 50ms timeout is deliberately conservative to allow
> for kernel scheduling latency, which can be significant under load or
> on slow machines.
>
> Fix the comment to state the correct conversion time, use "lowest sample
> rate" for clarity, and explain that the extra margin exists to absorb
> scheduling latency so that no one is tempted to shrink the timeout to
> match the conversion period.
...
> - /* Cannot take longer than 40ms (250Hz) */
> + /* One conversion takes at most 4ms at the lowest sample rate (250Hz).
> + * Use 50ms to allow for kernel scheduling latency.
> + */
/*
* This is wrong style of multi-line comments in the IIO
* subsystem. Use this example on how to fix it.
*/
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-10 10:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260509071910.12345-1-shofiqtest@gmail.com>
2026-05-10 8:45 ` [PATCH v2] iio: adc: ti-ads1298: Fix incorrect timeout comment Md Shofiqul Islam
2026-05-10 10:16 ` Andy Shevchenko [this message]
2026-05-10 12:38 ` [PATCH v3] " Md Shofiqul Islam
2026-05-10 13:01 ` Andy Shevchenko
2026-05-10 19:34 ` [PATCH v4] " Md Shofiqul Islam
2026-05-10 19:36 ` Md Shofiqul Islam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agBbCCWdkh7rJdxb@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=nuno.sa@analog.com \
--cc=shofiqtest@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox