Re: [RFC 1/4] dt-bindings: iio: light: add DT binding for Broadcom APDS9999

[Jonathan Cameron <jic23@kernel.org>]

On Mon, 11 May 2026 12:14:44 +0200
"Jose A. Perez de Azpillaga" <azpijr@gmail.com> wrote:

Title doesn't need to mention binding twice.

dt-bindings: iio: light: add Broadcomm ADPS9999

> Add Device Tree binding documentation for the Broadcom APDS9999
> ambient light sensor.
> 
> Proximity and RGB features are not yet implemented in the driver
> and therefore not included in this binding.
> 
> Signed-off-by: Jose A. Perez de Azpillaga <azpijr@gmail.com>

Can you combine this with the existing avago,apds9300.yaml binding?
Other than the missing interrupt in this file they look identical.

Note that a separate driver doesn't necessarily need a separate binding
doc.  May not be worth doing given the extra supply this part takes
(which you are currently missing by the look of it)

Other comments inline.

Thanks,

Jonathan

 
> ---
>  .../bindings/iio/light/brcm,apds9999.yaml     | 33 +++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> new file mode 100644
> index 000000000000..b20ef3677670
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/brcm,apds9999.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/light/brcm,apds9999.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +title: Broadcom APDS-9999 Ambient Light Sensor
> +maintainers:
> +  - Jose A. Perez de Azpillaga <azpijr@gmail.com>
> +description: |
> +  Datasheet: https://docs.broadcom.com/docs/APDS-9999-DS
> +
> +properties:
> +  compatible:
> +    enum:
> +      - brcm,apds9999
blank line.  In general add some more above as well. Just follow style of
other similar files.

> +  reg:
> +    maxItems: 1
Blank line normal here.
> +  vdd-supply: true
and here
> +additionalProperties: false
and here
> +required:
> +  - compatible
> +  - reg
and here

Power supply should be required
Also you need to fully describe the part where possible. Here there
is an interrupt and a vcsel-supply by the look of it.

> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +        light-sensor@52 {
> +            compatible = "brcm,apds9999";
> +            reg = <0x52>;
> +            vdd-supply = <&vdd_reg>;
> +        };
> +    };