Linux IIO development
 help / color / mirror / Atom feed
From: Abinash Singh <abinashsinghlalotra@gmail.com>
To: jic23@kernel.org, gregkh@linuxfoundation.org
Cc: dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
	linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	Abinash Singh <abinashlalotra@gmail.com>
Subject: [PATCH] staging: Documentation: dds: replace frequencyY with frequency
Date: Mon, 11 May 2026 22:42:55 +0530	[thread overview]
Message-ID: <20260511171255.9668-1-abinashsinghlalotra@gmail.com> (raw)

From: Abinash Singh <abinashlalotra@gmail.com>

The documented frequencyY attribute naming is implementation
specific and differs from common IIO sysfs attribute
conventions.

Replace the non-standard frequencyY attribute documentation with
out_altvoltageX_frequency and document tuning word selection
through out_altvoltageX_frequencysymbol

This makes the documented ABI naming consistent with standard
IIO sysfs attribute conventions and clarifies how tuning word
registers are selected and programmed.


Signed-off-by: Abinash Singh <abinashlalotra@gmail.com>
---

The out_altvoltageX_frequencysymbol and
out_altvoltageX_frequency_scale attributes can be added
through extended channel attributes (.ext_info in channel_spec struct of IIO)

Feedback on this approach would be appreciated, and if
there is some other way in your mind. I would like to 
work on that.

I am also interested in working on the sysfs-bus-iio-dds
documentation and the ad9834 driver. I recently bought an
AD9833 IC for experimentation and testing.

Thanks

 .../iio/Documentation/sysfs-bus-iio-dds       | 31 ++++++++++---------
 1 file changed, 16 insertions(+), 15 deletions(-)

diff --git a/drivers/staging/iio/Documentation/sysfs-bus-iio-dds b/drivers/staging/iio/Documentation/sysfs-bus-iio-dds
index ee8c509c6733..dfc6ae3964d1 100644
--- a/drivers/staging/iio/Documentation/sysfs-bus-iio-dds
+++ b/drivers/staging/iio/Documentation/sysfs-bus-iio-dds
@@ -1,33 +1,34 @@
 
-What:		/sys/bus/iio/devices/.../out_altvoltageX_frequencyY
+What:		/sys/bus/iio/devices/.../out_altvoltageX_frequency
 KernelVersion:	2.6.37
 Contact:	linux-iio@vger.kernel.org
 Description:
-		Stores frequency into tuning word Y.
-		There will be more than one out_altvoltageX_frequencyY file,
-		which allows for pin controlled FSK Frequency Shift Keying
-		(out_altvoltageX_pincontrol_frequency_en is active) or the user
-		can control the desired active tuning word by writing Y to the
+		Stores frequency into active tuning word register.
+		To select active tuning word register, the user
+		must write the desired index to the
 		out_altvoltageX_frequencysymbol file.
+		For pin controlled FSK (Frequency Shift Keying),
+		tuning word registers must be loaded by selecting
+		each via out_altvoltageX_frequencysymbol before enabling
+		out_altvoltageX_pincontrol_frequency_en.
 
-What:		/sys/bus/iio/devices/.../out_altvoltageX_frequencyY_scale
+What:		/sys/bus/iio/devices/.../out_altvoltageX_frequency_scale
 KernelVersion:	2.6.37
 Contact:	linux-iio@vger.kernel.org
 Description:
-		Scale to be applied to out_altvoltageX_frequencyY in order to
-		obtain the desired value in Hz. If shared across all frequency
-		registers Y is not present. It is also possible X is not present
+		Scale to be applied to out_altvoltageX_frequency in order to
+		obtain the desired value in Hz. It is also possible X is not present
 		if shared across all channels.
 
 What:		/sys/bus/iio/devices/.../out_altvoltageX_frequencysymbol
 KernelVersion:	2.6.37
 Contact:	linux-iio@vger.kernel.org
 Description:
-		Specifies the active output frequency tuning word. The value
-		corresponds to the Y in out_altvoltageX_frequencyY.
-		To exit this mode the user can write
-		out_altvoltageX_pincontrol_frequency_en or
-		out_altvoltageX_out_enable file.
+		Specifies the active output frequency tuning word index.
+		Writing an index here selects which tuning word register
+		is written by out_altvoltageX_frequency. To exit this mode
+		the user can write out_altvoltageX_pincontrol_frequency_en
+		or out_altvoltageX_out_enable file.
 
 What:		/sys/bus/iio/devices/.../out_altvoltageX_phaseY
 KernelVersion:	2.6.37
-- 
2.43.0


             reply	other threads:[~2026-05-11 17:13 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11 17:12 Abinash Singh [this message]
2026-05-12 11:15 ` [PATCH] staging: Documentation: dds: replace frequencyY with frequency Andy Shevchenko
2026-05-12 16:31   ` Abinash Singh
2026-05-12 14:08 ` Jonathan Cameron
2026-05-12 16:44   ` Abinash Singh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511171255.9668-1-abinashsinghlalotra@gmail.com \
    --to=abinashsinghlalotra@gmail.com \
    --cc=abinashlalotra@gmail.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-staging@lists.linux.dev \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox