From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Abinash Singh <abinashsinghlalotra@gmail.com>
Cc: jic23@kernel.org, gregkh@linuxfoundation.org,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
linux-iio@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org,
Abinash Singh <abinashlalotra@gmail.com>
Subject: Re: [PATCH] staging: Documentation: dds: replace frequencyY with frequency
Date: Tue, 12 May 2026 14:15:51 +0300 [thread overview]
Message-ID: <agML51XAy3kSGhpa@ashevche-desk.local> (raw)
In-Reply-To: <20260511171255.9668-1-abinashsinghlalotra@gmail.com>
On Mon, May 11, 2026 at 10:42:55PM +0530, Abinash Singh wrote:
> The documented frequencyY attribute naming is implementation
I'm lost here. What frequencyY? I don't see that in the patch.
I think this needs to be more specific. Can you rephrase?
> specific and differs from common IIO sysfs attribute
> conventions.
>
> Replace the non-standard frequencyY attribute documentation with
> out_altvoltageX_frequency and document tuning word selection
> through out_altvoltageX_frequencysymbol
Missing space?
> This makes the documented ABI naming consistent with standard
> IIO sysfs attribute conventions and clarifies how tuning word
> registers are selected and programmed.
>
>
(A single blank line is enough.)
> Signed-off-by: Abinash Singh <abinashlalotra@gmail.com>
> ---
>
> The out_altvoltageX_frequencysymbol and
> out_altvoltageX_frequency_scale attributes can be added
> through extended channel attributes (.ext_info in channel_spec struct of IIO)
>
> Feedback on this approach would be appreciated, and if
> there is some other way in your mind. I would like to
> work on that.
>
> I am also interested in working on the sysfs-bus-iio-dds
> documentation and the ad9834 driver. I recently bought an
> AD9833 IC for experimentation and testing.
I didn't get is the current documentation wrong or is it that currently
used ABI is wrong?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-12 11:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 17:12 [PATCH] staging: Documentation: dds: replace frequencyY with frequency Abinash Singh
2026-05-12 11:15 ` Andy Shevchenko [this message]
2026-05-12 16:31 ` Abinash Singh
2026-05-12 14:08 ` Jonathan Cameron
2026-05-12 16:44 ` Abinash Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agML51XAy3kSGhpa@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=abinashlalotra@gmail.com \
--cc=abinashsinghlalotra@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox