From: Jonathan Cameron <jic23@kernel.org>
To: Stepan Ionichev <sozdayvek@gmail.com>
Cc: andriy.shevchenko@intel.com, joshua.crofts1@gmail.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, hcazarim@yahoo.com,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: trigger: iio-trig-interrupt: use devm_* helpers
Date: Sat, 16 May 2026 12:24:17 +0100 [thread overview]
Message-ID: <20260516122417.389add6f@jic23-huawei> (raw)
In-Reply-To: <20260513083342.764-1-sozdayvek@gmail.com>
On Wed, 13 May 2026 13:33:42 +0500
Stepan Ionichev <sozdayvek@gmail.com> wrote:
> On Mon, May 11, 2026 at 19:56, Jonathan Cameron wrote:
> > Silly question for you - how does this driver actually bind on a
> > modern platform? That is - how do we get one of these?
>
> It does not, as far as I can see.
>
> Grep across the mainline tree:
>
> - The string "iio_interrupt_trigger" appears only in the driver itself
> (drivers/iio/trigger/iio-trig-interrupt.c:101 — the .driver.name).
> - No .of_match_table and no .id_table on the driver.
> - No platform_device_register*() call anywhere in arch/, drivers/ or
> board files that would create a device named "iio_interrupt_trigger".
> - No Documentation/devicetree/bindings/ entry.
>
> So the only way to instantiate it on a current kernel is an explicit
> out-of-tree platform_device_register("iio_interrupt_trigger", ...), and
> nothing in mainline does that.
>
> Given that, please drop v1 and v2 of this patch. The cleanup-for-its-
> own-sake is not worth the parent / sysfs-hierarchy change Andy flagged
> when there are no in-tree users to validate it against.
>
> If at some point a user appears in mainline (DT binding, ACPI hookup
> or a board file), the devm_* conversion can come along with that work.
>
> Sorry for the noise.
No problem! You got us looking at it.
So wider question for anyone reading - do we actually want to keep
this driver? Meh, to catch peoples attention better than in this
thread I'll propose a patch dropping it and see what responses we get.
Jonathan
>
> Stepan
next prev parent reply other threads:[~2026-05-16 11:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 6:07 [PATCH] iio: trigger: iio-trig-interrupt: use devm_* helpers Stepan Ionichev
2026-05-11 6:32 ` [PATCH v2] " Stepan Ionichev
2026-05-11 13:53 ` Joshua Crofts
2026-05-11 14:56 ` Jonathan Cameron
2026-05-11 15:05 ` Andy Shevchenko
2026-05-11 6:36 ` [PATCH] " Stepan Ionichev
2026-05-11 6:44 ` Stepan Ionichev
2026-05-11 13:33 ` Joshua Crofts
2026-05-11 6:27 ` Stepan Ionichev
2026-05-11 13:48 ` Joshua Crofts
2026-05-11 13:46 ` Andy Shevchenko
2026-05-11 13:38 ` Andy Shevchenko
2026-05-13 8:33 ` Stepan Ionichev
2026-05-16 11:24 ` Jonathan Cameron [this message]
2026-05-17 7:13 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260516122417.389add6f@jic23-huawei \
--to=jic23@kernel.org \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=hcazarim@yahoo.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=sozdayvek@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox